Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1226143007: Revert of Re-add -Wno-missing-braces on win clang. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-add -Wno-missing-braces on win clang. (patchset #1 id:1 of https://codereview.chromium.org/1222203012/) Reason for revert: ANGLE has rolled in https://crrev.com/01b5c82d06fcbddd7556ea848ba803b72c61811c Original issue's description: > Re-add -Wno-missing-braces on win clang. > > ANGLE needs a roll to fix one last instance of this warning, but the > roll is currently blocked. Disable this warning again until ANGLE can be > successfully rolled to fda3ec747c3dca037b961c7f8c04a81766f37007. > > BUG=505297 > R=thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/c38a1f71038e5f0a5565b42e30b8985870b49286 TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=505297 Committed: https://crrev.com/67c725e3ec44956a961ab8795efb3fcb369f4fe7 Cr-Commit-Position: refs/heads/master@{#338234}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
dcheng
Created Revert of Re-add -Wno-missing-braces on win clang.
5 years, 5 months ago (2015-07-09 20:43:45 UTC) #1
Nico
lgtm
5 years, 5 months ago (2015-07-09 20:44:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226143007/1
5 years, 5 months ago (2015-07-09 20:45:01 UTC) #3
commit-bot: I haz the power
Failed to apply patch for build/common.gypi: While running git apply --index -3 -p1; error: patch ...
5 years, 5 months ago (2015-07-09 20:46:46 UTC) #5
Nico
rebase rebase rebase
5 years, 5 months ago (2015-07-10 02:56:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226143007/70001
5 years, 5 months ago (2015-07-10 03:07:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:70001)
5 years, 5 months ago (2015-07-10 03:08:04 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 03:09:56 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67c725e3ec44956a961ab8795efb3fcb369f4fe7
Cr-Commit-Position: refs/heads/master@{#338234}

Powered by Google App Engine
This is Rietveld 408576698