sky/sdk/lib/widgets/fixed_height_scrollable.dart - Issue 1226133004: Switch scroll physics over to using newton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/fixed_height_scrollable.dart

Issue 1226133004: Switch scroll physics over to using newton (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: analyzer nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/widgets/fixed_height_scrollable.dart

diff --git a/sky/sdk/lib/widgets/fixed_height_scrollable.dart b/sky/sdk/lib/widgets/fixed_height_scrollable.dart

index e4dc1f4c7f7be38dc2dcafac64bbb5afabebd4c0..bc81eacfda69f50cd3ba2598d903c54b06c669e0 100644

--- a/sky/sdk/lib/widgets/fixed_height_scrollable.dart

+++ b/sky/sdk/lib/widgets/fixed_height_scrollable.dart

@@ -38,7 +38,7 @@ abstract class FixedHeightScrollable extends Scrollable {

void _handleSizeChanged(Size newSize) {

setState(() {

_height = newSize.height;

- scrollBehavior.containerHeight = _height;

+ scrollBehavior.containerSize = _height;

});

}

@@ -46,7 +46,7 @@ abstract class FixedHeightScrollable extends Scrollable {

double contentsHeight = itemHeight * itemCount;

if (padding != null)

contentsHeight += padding.top + padding.bottom;

- scrollBehavior.contentsHeight = contentsHeight;

+ scrollBehavior.contentsSize = contentsHeight;

}

void _updateScrollOffset() {

« no previous file with comments | « sky/sdk/lib/animation/scroll_behavior.dart ('k') | sky/sdk/lib/widgets/scrollable.dart » ('j') | no next file with comments »