Issue 1226133004: Switch scroll physics over to using newton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226133004: Switch scroll physics over to using newton (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Chinmay

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Switch scroll physics over to using newton The scroll physics was the last client of the old frame generator. With this change, we've fully switched over to the new animation system. R=chinmaygarde@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f8254efa4fd7c97bd71de8af01c8cf3f35d0ee5e

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -434 lines)			Patch
M	sky/sdk/BUILD.gn	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/sdk/example/widgets/card_collection.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A	sky/sdk/lib/animation/animated_simulation.dart	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download
D	sky/sdk/lib/animation/generators.dart	View		1 chunk	+0 lines, -95 lines	0 comments	Download
D	sky/sdk/lib/animation/mechanics.dart	View		1 chunk	+0 lines, -213 lines	0 comments	Download
M	sky/sdk/lib/animation/scroll_behavior.dart	View		1 chunk	+46 lines, -72 lines	0 comments	Download
M	sky/sdk/lib/widgets/fixed_height_scrollable.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/scrollable.dart	View		6 chunks	+18 lines, -18 lines	0 comments	Download
M	sky/sdk/lib/widgets/tabs.dart	View	1 2 3	5 chunks	+5 lines, -28 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-10 22:48:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
f8254efa4fd7c97bd71de8af01c8cf3f35d0ee5e (presubmit successful).