Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 122613004: Report known bisect results at the end of each step. (Closed)

Created:
6 years, 11 months ago by shatch
Modified:
6 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Report known bisect results at the end of each step. This will allow jobs that fail unexpectedly to be easily resubmitted with a reduced range by perf sheriffs. Example output: @@@SEED_STEP Working on [519ed0d5835fc914eb6d320eb7f4e0dbd3c60c8d]@@@ @@@STEP_CURSOR Working on [519ed0d5835fc914eb6d320eb7f4e0dbd3c60c8d]@@@ @@@STEP_STARTED@@@ Working on revision: [519ed0d5835fc914eb6d320eb7f4e0dbd3c60c8d] Partial results: Depot Commit SHA Mean Std. Error State chromium 400664c4101576b48e30da67d57ecffc4d83fcb0 0.00 +-0.00 Bad chromium fc062604f35d88e607e36ae5f91d19d7cb2251a2 0.00 +-0.00 Bad chromium 1ce4152989e2d33fa10278b4f20267afa70d6be3 0.00 +-0.00 Bad chromium 519ed0d5835fc914eb6d320eb7f4e0dbd3c60c8d 0.00 +-0.00 Bad chromium 481936425a29b2ef6796a1185a8f9008c282b346 0.00 +-0.00 Good @@@STEP_CLOSED@@@ BUG=331802 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243200

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes from review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M tools/bisect-perf-regression.py View 1 5 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shatch
6 years, 11 months ago (2014-01-06 22:35:52 UTC) #1
tonyg
lgtm https://codereview.chromium.org/122613004/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/122613004/diff/1/tools/bisect-perf-regression.py#newcode2263 tools/bisect-perf-regression.py:2263: for current_id, current_data in revision_data_sorted: Seems like there ...
6 years, 11 months ago (2014-01-06 22:44:57 UTC) #2
shatch
https://codereview.chromium.org/122613004/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/122613004/diff/1/tools/bisect-perf-regression.py#newcode2263 tools/bisect-perf-regression.py:2263: for current_id, current_data in revision_data_sorted: On 2014/01/06 22:44:57, tonyg ...
6 years, 11 months ago (2014-01-06 23:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/122613004/60001
6 years, 11 months ago (2014-01-06 23:36:30 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 23:39:05 UTC) #5
Message was sent while issue was closed.
Change committed as 243200

Powered by Google App Engine
This is Rietveld 408576698