Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1226123012: Remove rt flags that are not necessary (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 5 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tests/FloatingPointTextureTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
5 years, 5 months ago (2015-07-16 16:18:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226123012/1
5 years, 5 months ago (2015-07-16 16:18:51 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 5 months ago (2015-07-16 16:18:52 UTC) #5
joshualitt
On 2015/07/16 16:18:52, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 5 months ago (2015-07-16 16:20:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b6b0a6ef179f4143c94ba7e0e1be6e7ce4b0a23a
5 years, 5 months ago (2015-07-16 16:35:09 UTC) #7
bsalomon
5 years, 5 months ago (2015-07-16 16:59:55 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1234503004/ by bsalomon@google.com.

The reason for reverting is: breaks tests, e.g. 
https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Ne....

Powered by Google App Engine
This is Rietveld 408576698