Index: src/arm/full-codegen-arm.cc |
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc |
index d15f44ad2c29ecd7d8af0c3f7a3cb7e170d7ec5b..af36f44cc896e2b6dc884b909a096269df6da10e 100644 |
--- a/src/arm/full-codegen-arm.cc |
+++ b/src/arm/full-codegen-arm.cc |
@@ -2000,7 +2000,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
void FullCodeGenerator::VisitAssignment(Assignment* expr) { |
- DCHECK(expr->target()->IsValidReferenceExpression()); |
+ DCHECK(expr->target()->IsValidReferenceExpressionOrThis()); |
Comment cmnt(masm_, "[ Assignment"); |
SetExpressionPosition(expr, INSERT_BREAK); |
@@ -2677,7 +2677,7 @@ void FullCodeGenerator::EmitBinaryOp(BinaryOperation* expr, Token::Value op) { |
void FullCodeGenerator::EmitAssignment(Expression* expr, |
FeedbackVectorICSlot slot) { |
- DCHECK(expr->IsValidReferenceExpression()); |
+ DCHECK(expr->IsValidReferenceExpressionOrThis()); |
Property* prop = expr->AsProperty(); |
LhsKind assign_type = Property::GetAssignType(prop); |
@@ -2825,6 +2825,20 @@ void FullCodeGenerator::EmitVariableAssignment(Variable* var, Token::Value op, |
__ bind(&const_error); |
__ CallRuntime(Runtime::kThrowConstAssignError, 0); |
+ } else if (var->is_this() && op == Token::INIT_CONST) { |
+ // Initializing assignment to const {this} needs a write barrier. |
+ DCHECK(var->IsStackAllocated() || var->IsContextSlot()); |
+ Label uninitialized_this; |
+ MemOperand location = VarOperand(var, r1); |
+ __ ldr(r3, location); |
+ __ CompareRoot(r3, Heap::kTheHoleValueRootIndex); |
+ __ b(eq, &uninitialized_this); |
+ __ mov(r0, Operand(var->name())); |
+ __ Push(r0); |
+ __ CallRuntime(Runtime::kThrowReferenceError, 1); |
+ __ bind(&uninitialized_this); |
+ EmitStoreToStackLocalOrContextSlot(var, location); |
+ |
} else if (!var->is_const_mode() || op == Token::INIT_CONST) { |
if (var->IsLookupSlot()) { |
// Assignment to var. |
@@ -3176,22 +3190,6 @@ void FullCodeGenerator::EmitResolvePossiblyDirectEval(int arg_count) { |
} |
-void FullCodeGenerator::EmitInitializeThisAfterSuper( |
- SuperCallReference* super_ref, FeedbackVectorICSlot slot) { |
- Variable* this_var = super_ref->this_var()->var(); |
- GetVar(r1, this_var); |
- __ CompareRoot(r1, Heap::kTheHoleValueRootIndex); |
- Label uninitialized_this; |
- __ b(eq, &uninitialized_this); |
- __ mov(r0, Operand(this_var->name())); |
- __ Push(r0); |
- __ CallRuntime(Runtime::kThrowReferenceError, 1); |
- __ bind(&uninitialized_this); |
- |
- EmitVariableAssignment(this_var, Token::INIT_CONST, slot); |
-} |
- |
- |
// See http://www.ecma-international.org/ecma-262/6.0/#sec-function-calls. |
void FullCodeGenerator::PushCalleeAndWithBaseObject(Call* expr) { |
VariableProxy* callee = expr->expression()->AsVariableProxy(); |
@@ -3413,7 +3411,6 @@ void FullCodeGenerator::EmitSuperConstructorCall(Call* expr) { |
RecordJSReturnSite(expr); |
- EmitInitializeThisAfterSuper(super_call_ref, expr->CallFeedbackICSlot()); |
context()->Plug(r0); |
} |
@@ -4744,9 +4741,6 @@ void FullCodeGenerator::EmitCallSuperWithSpread(CallRuntime* expr) { |
// Restore context register. |
__ ldr(cp, MemOperand(fp, StandardFrameConstants::kContextOffset)); |
context()->DropAndPlug(1, r0); |
- |
- // TODO(mvstanton): with FLAG_vector_stores this needs a slot id. |
- EmitInitializeThisAfterSuper(super_call_ref); |
} |
@@ -4944,7 +4938,7 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) { |
void FullCodeGenerator::VisitCountOperation(CountOperation* expr) { |
- DCHECK(expr->expression()->IsValidReferenceExpression()); |
+ DCHECK(expr->expression()->IsValidReferenceExpressionOrThis()); |
Comment cmnt(masm_, "[ CountOperation"); |