Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1226123010: Represent implicit 'this' binding by 'super' in AST. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/ast-loop-assignment-analyzer.h" 5 #include "src/compiler/ast-loop-assignment-analyzer.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/parser.h" 7 #include "src/parser.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 154
155 void ALAA::VisitProperty(Property* e) { 155 void ALAA::VisitProperty(Property* e) {
156 Visit(e->obj()); 156 Visit(e->obj());
157 Visit(e->key()); 157 Visit(e->key());
158 } 158 }
159 159
160 160
161 void ALAA::VisitCall(Call* e) { 161 void ALAA::VisitCall(Call* e) {
162 Visit(e->expression()); 162 Visit(e->expression());
163 VisitExpressions(e->arguments()); 163 VisitExpressions(e->arguments());
164 // TODO(mstarzinger): It sure would be nice if this were desugared.
165 if (e->GetCallType(isolate()) == Call::SUPER_CALL) {
166 SuperCallReference* super = e->expression()->AsSuperCallReference();
167 AnalyzeAssignment(super->this_var()->var());
168 }
169 } 164 }
170 165
171 166
172 void ALAA::VisitCallNew(CallNew* e) { 167 void ALAA::VisitCallNew(CallNew* e) {
173 Visit(e->expression()); 168 Visit(e->expression());
174 VisitExpressions(e->arguments()); 169 VisitExpressions(e->arguments());
175 } 170 }
176 171
177 172
178 void ALAA::VisitCallRuntime(CallRuntime* e) { 173 void ALAA::VisitCallRuntime(CallRuntime* e) {
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 int count = 0; 289 int count = 0;
295 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var); 290 int var_index = AstLoopAssignmentAnalyzer::GetVariableIndex(scope, var);
296 for (size_t i = 0; i < list_.size(); i++) { 291 for (size_t i = 0; i < list_.size(); i++) {
297 if (list_[i].second->Contains(var_index)) count++; 292 if (list_[i].second->Contains(var_index)) count++;
298 } 293 }
299 return count; 294 return count;
300 } 295 }
301 } // namespace compiler 296 } // namespace compiler
302 } // namespace internal 297 } // namespace internal
303 } // namespace v8 298 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698