Issue 1226113002: Move protocol registration from WebViewClient to WebFrameClient, part 2/3.

Issue 1226113002: Move protocol registration from WebViewClient to WebFrameClient, part 2/3. (Closed)

Created:
5 years, 5 months ago by Avi (use Gerrit)

Modified:
5 years, 5 months ago

Reviewers:
dcheng, pfeldman, nasko

CC:
blink-reviews, dglazkov+blink, gyuyoung2, site-isolation-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Move protocol registration from WebViewClient to WebFrameClient, part 2/3. BUG=304341 TEST=protocol registration still works Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198608

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -51 lines)			Patch
M	Source/modules/navigatorcontentutils/NavigatorContentUtils.h	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp	View	6 chunks	+7 lines, -11 lines	0 comments	Download
M	Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/modules/navigatorcontentutils/testing/InternalsNavigatorContentUtils.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/NavigatorContentUtilsClientImpl.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/web/NavigatorContentUtilsClientImpl.cpp	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	public/web/WebFrameClient.h	View	2 chunks	+17 lines, -0 lines	0 comments	Download
M	public/web/WebViewClient.h	View	2 chunks	+0 lines, -17 lines	0 comments	Download

Total messages: 13 (5 generated)

Avi (use Gerrit)

Pavel: This is a sandwich; parts 1 and 3 are plain and boring (https://codereview.chromium.org/1228713003/ and ...

5 years, 5 months ago (2015-07-08 21:43:01 UTC) #2

Avi (use Gerrit)

On 2015/07/08 21:43:01, Avi wrote: > Pavel: > > This is a sandwich; parts 1 ...

5 years, 5 months ago (2015-07-08 21:43:38 UTC) #3

pfeldman

I'm not a site isolation person, but this change is mechanical, so lgtm. You might ...

5 years, 5 months ago (2015-07-09 05:49:32 UTC) #4

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226113002/1

5 years, 5 months ago (2015-07-09 12:31:37 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226113002/1

5 years, 5 months ago (2015-07-09 14:22:37 UTC) #12

commit-bot: I haz the power

5 years, 5 months ago (2015-07-09 14:26:14 UTC) #13

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198608