Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 12261039: Include OpenSans font in the web-app. (Closed)

Created:
7 years, 10 months ago by Jamie
Modified:
7 years, 10 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Include OpenSans font in the web-app. The is the simplest way of loading the font for Apps v2, and will improve the start-up time for the app. BUG=134213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182596

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added copyright header. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M remoting/remoting.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/webapp/main.html View 1 chunk +1 line, -2 lines 0 comments Download
A remoting/webapp/open_sans.css View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + remoting/webapp/open_sans.woff View Binary file 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie
ptal
7 years, 10 months ago (2013-02-14 19:35:51 UTC) #1
garykac
https://codereview.chromium.org/12261039/diff/1/remoting/webapp/main.html File remoting/webapp/main.html (right): https://codereview.chromium.org/12261039/diff/1/remoting/webapp/main.html#newcode12 remoting/webapp/main.html:12: <link rel="stylesheet" href="open_sans.css"> Why not use the Google Web ...
7 years, 10 months ago (2013-02-15 01:25:49 UTC) #2
garykac
On 2013/02/15 01:25:49, garykac wrote: > https://codereview.chromium.org/12261039/diff/1/remoting/webapp/main.html > File remoting/webapp/main.html (right): > > https://codereview.chromium.org/12261039/diff/1/remoting/webapp/main.html#newcode12 > ...
7 years, 10 months ago (2013-02-15 01:27:08 UTC) #3
garykac
7 years, 10 months ago (2013-02-15 01:27:14 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698