Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1226103003: Factor RenderBlock out into a base class and a subclass. (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Factor RenderBlock out into a base class and a subclass. The core parts of RenderBlock will be reused by: https://codereview.chromium.org/1222913013/ R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b9e2a7fd2bb21933c4dd23354a35a2d83bdc3be8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M sky/sdk/lib/rendering/block.dart View 3 chunks +36 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-09 00:43:50 UTC) #2
Hixie
5 years, 5 months ago (2015-07-09 00:55:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b9e2a7fd2bb21933c4dd23354a35a2d83bdc3be8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698