Don't switch to fake audio output until stream open fails.

media/audio/audio_manager_base.cc

Index: media/audio/audio_manager_base.cc
diff --git a/media/audio/audio_manager_base.cc b/media/audio/audio_manager_base.cc
index b4538775108012e6121f72bf0c474a066970535b..95935a66a4f2ef4326558f186b5ab28da0dfdb48 100644
--- a/media/audio/audio_manager_base.cc
+++ b/media/audio/audio_manager_base.cc
@@ -104,12 +104,6 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStream(
     return NULL;
   }
 
-  // If there are no audio output devices we should use a FakeAudioOutputStream
-  // to ensure video playback continues to work.
-  bool audio_output_disabled =
-      params.format() == AudioParameters::AUDIO_FAKE ||
-      !HasAudioOutputDevices();

[scherkus (not reviewing), 2013/02/15 18:43:37]

FYI this appeared to be the only production code use of HasAudioOutputDevices()
-- the rest were unit tests

now that we have proper fallback support, technically we could remove the check
from tests and they'd run again a fake device. not sure how useful that is
though.

[DaleCurtis, 2013/02/15 18:51:39]

Yeah, that's why I was looking at this originally. I think we can remove the
method, but we definitely can't remove HasAudioInputDevices(), so I'm wondering
if it it's best to keep both for symmetry. I believe most implementations use a
common "find devices" method and vary the input vs output parameter.

-
   AudioOutputStream* stream = NULL;
   if (virtual_audio_input_stream_) {
 #if defined(OS_IOS)
@@ -122,7 +116,7 @@ AudioOutputStream* AudioManagerBase::MakeAudioOutputStream(
         base::Bind(&AudioManagerBase::ReleaseVirtualOutputStream,
                    base::Unretained(this)));
 #endif
-  } else if (audio_output_disabled) {
+  } else if (params.format() == AudioParameters::AUDIO_FAKE) {
     stream = FakeAudioOutputStream::MakeFakeStream(this, params);
   } else if (params.format() == AudioParameters::AUDIO_PCM_LINEAR) {
     stream = MakeLinearOutputStream(params);