Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: tools/PRESUBMIT.py

Issue 12261026: Added separate checkout and config file generation to bisect script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved files. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/bisect-perf-regression.py » ('j') | tools/bisect-perf-regression.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 """Top-level presubmit script for bisect trybot.
6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into gcl.
9 """
10
11 import imp
12
13 def _ExamineBisectConfigFile(input_api, output_api):
14 for f in input_api.AffectedFiles():
15 if not f.LocalPath().endswith('run-bisect-perf-regression.cfg'):
16 continue
17
18 try:
19 cfg_file = imp.load_source('config', 'run-bisect-perf-regression.cfg')
20
21 for k, v in cfg_file.config.iteritems():
22 if v:
23 return f.LocalPath()
24 except (IOError, AttributeError, TypeError):
25 return f.LocalPath()
26
27 return None
28
29 def _CheckNoChangesToBisectConfigFile(input_api, output_api):
30 results = _ExamineBisectConfigFile(input_api, output_api)
31 if results:
32 return [output_api.PresubmitError(
33 'The bisection config file should only contain a config dict with '
34 'empty fields. Changes to this file should never be submitted.',
35 items=[results])]
36
37 return []
38
39 def CommonChecks(input_api, output_api):
40 results = []
41 results.extend(_CheckNoChangesToBisectConfigFile(input_api, output_api))
42 return results
43
44 def CheckChangeOnUpload(input_api, output_api):
45 return CommonChecks(input_api, output_api)
46
47 def CheckChangeOnCommit(input_api, output_api):
48 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | tools/bisect-perf-regression.py » ('j') | tools/bisect-perf-regression.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698