build/util/run-bisect-perf-regression.cfg - Issue 12261026: Added separate checkout and config file generation to bisect script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/util/run-bisect-perf-regression.cfg

Issue 12261026: Added separate checkout and config file generation to bisect script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """Config file for Run Performance Test Bisect Tool

	6

	7 This script is used by the run-bisect-perf-regression.py script.
	tonyg 2013/02/14 01:03:43 Recommend beefing up this description to describe Recommend beefing up this description to describe exactly how this file is meant to be used (since it is a little unusual). e.g. mention to edit, run git try <bot>, and never submit changes. shatch 2013/02/14 23:00:34 Done. Show quoted text On 2013/02/14 01:03:43, tonyg wrote: > Recommend beefing up this description to describe exactly how this file is meant > to be used (since it is a little unusual). e.g. mention to edit, run git try > <bot>, and never submit changes. Done.
	8

	9 Sample config:

	10

	11 config =\

	12 {

	13 'command':'./out/Release/performance_ui_tests' +

	14 ' --gtest_filter=PageCyclerTest.Intl1File',

	15 'good_revision':'179755',

	16 'bad_revision':'179782',

	17 'metric':'times/t'

	18 }

	19

	20 """

	21

	22 config =\
	tonyg 2013/02/14 01:03:43 I think we should have a PRESUBMIT.py check that v I think we should have a PRESUBMIT.py check that verifies that this config contains all empty fields. Otherwise, someone might accidentally check in their change that is meant only for the tryservers. Search for PRESUBMIT.py to see lots of examples in the codebase. shatch 2013/02/14 23:00:34 Done. Show quoted text On 2013/02/14 01:03:43, tonyg wrote: > I think we should have a PRESUBMIT.py check that verifies that this config > contains all empty fields. Otherwise, someone might accidentally check in their > change that is meant only for the tryservers. > > Search for PRESUBMIT.py to see lots of examples in the codebase. Done.
	23 {
	tonyg 2013/02/14 01:03:43 Recommend bringing this up to the line above here Recommend bringing this up to the line above here and in the sample shatch 2013/02/14 23:00:34 Done. Show quoted text On 2013/02/14 01:03:43, tonyg wrote: > Recommend bringing this up to the line above here and in the sample Done.
	24 'command':'',
	tonyg 2013/02/14 01:03:43 Recommend space after colons in this block and in Recommend space after colons in this block and in the sample shatch 2013/02/14 23:00:34 Done. Show quoted text On 2013/02/14 01:03:43, tonyg wrote: > Recommend space after colons in this block and in the sample Done.
	25 'good_revision':'',

	26 'bad_revision':'',

	27 'metric':'',

	28 }

OLD	NEW

« no previous file with comments | « no previous file | build/util/run-bisect-perf-regression.py » ('j') | build/util/run-bisect-perf-regression.py » ('J')