DescriptionEnsure that themes in desktop chrome AURA on Windows use the opaque browser frame view.
Relanding this as the original attempt caused a bunch of browser test and other failures because of an infinite
recursion crash. This occurred because the newly added helper function chrome::ShouldUseNativeFrame invoked the
ShouldUseNativeFrame function on the native widget passed in which as per this change calls back into the helper function
leading to an infinite recursion crash.
Fix is to only invoke the helper if the underlying native widget implementation of ShouldUseNativeFrame returns true.
This typically returns true if the aero theme is to be used on Windows.
To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
DesktopBrowserFrameAura::ShouldUseNativeFrame override.
The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function ShouldUseNativeFrame
in the chrome namespace in the newly added files browser_frame_common_win.h/.cc.
This is invoked from BrowserFrameWin and from the DesktopBrowserFrameAura overrides.
BUG=175372
R=sky
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182347
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 2 (0 generated)
|