Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 12261017: Ensure that themes in desktop chrome AURA on Windows use the opaque browser frame view. (Closed)

Created:
7 years, 10 months ago by ananta
Modified:
7 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Ensure that themes in desktop chrome AURA on Windows use the opaque browser frame view. Relanding this as the original attempt caused a bunch of browser test and other failures because of an infinite recursion crash. This occurred because the newly added helper function chrome::ShouldUseNativeFrame invoked the ShouldUseNativeFrame function on the native widget passed in which as per this change calls back into the helper function leading to an infinite recursion crash. Fix is to only invoke the helper if the underlying native widget implementation of ShouldUseNativeFrame returns true. This typically returns true if the aero theme is to be used on Windows. To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the DesktopBrowserFrameAura::ShouldUseNativeFrame override. The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function ShouldUseNativeFrame in the chrome namespace in the newly added files browser_frame_common_win.h/.cc. This is invoked from BrowserFrameWin and from the DesktopBrowserFrameAura overrides. BUG=175372 R=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182347

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -14 lines) Patch
M chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_root_window_host_win.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_frame_common_win.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_frame_common_win.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_win.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
7 years, 10 months ago (2013-02-13 21:09:58 UTC) #1
sky
7 years, 10 months ago (2013-02-13 22:19:48 UTC) #2
LGTM - in the future make the first patchset the original patch so I can easily
diff.

Powered by Google App Engine
This is Rietveld 408576698