Issue 12261011: Move sweeping pending status field of concurrent sweepers to MarkCompactCollector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12261011: Move sweeping pending status field of concurrent sweepers to MarkCompactCollector. (Closed)

Created:
7 years, 10 months ago by Hannes Payer (out of office)

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move sweeping pending status field of concurrent sweepers to MarkCompactCollector. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13661

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
M	src/mark-compact.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View		4 chunks	+5 lines, -4 lines	0 comments	Download
M	src/sweeper-thread.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/sweeper-thread.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/12261011/diff/1/src/mark-compact.h File src/mark-compact.h (right): https://codereview.chromium.org/12261011/diff/1/src/mark-compact.h#newcode743 src/mark-compact.h:743: bool sweeping_pending_; Please add a ...

7 years, 10 months ago (2013-02-13 15:16:11 UTC) #2

Hannes Payer (out of office)

7 years, 10 months ago (2013-02-13 15:20:58 UTC) #3

https://codereview.chromium.org/12261011/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

https://codereview.chromium.org/12261011/diff/1/src/mark-compact.h#newcode743
src/mark-compact.h:743: bool sweeping_pending_;
On 2013/02/13 15:16:11, Michael Starzinger wrote:
> Please add a short comment to this predicate explaining it's semantics.
> Especially that it's used for parallel and concurrent sweeping (not for lazy
> sweeping).

Done.

Expand Messages | Collapse Messages

Issue 12261011: Move sweeping pending status field of concurrent sweepers to MarkCompactCollector. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages