Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1226093008: Revert of Flush pending writes on Skia scratch textures used in Chromium (Closed)

Created:
5 years, 5 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, mlamouri+watch-media_chromium.org, reed1, bsalomon_chromium, no sievers, boliu, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flush pending writes on Skia scratch textures used in Chromium (patchset #4 id:60001 of https://codereview.chromium.org/1225583003/) Reason for revert: Broke three video-related WebGL conformance tests on Nexus 5; see https://code.google.com/p/chromium/issues/detail?id=504773#c3 . Original issue's description: > Flush pending writes on Skia scratch textures used in Chromium > > Chromium uses textures allocated by Skia's internal resource manager for > video rendering. In case the textures are recycled, they might have > pending write operations on them. Most commonly they have a pending > framebuffer discard that gets inserted when a texture is chosen for > recycling. These pending operations need to be flushed before the texture > is accessed outside of Skia. Otherwise it's possible that the pending > operations get deferred until after Chromium uses the texture. > > In other words, we need to guarantee that the order of operations is: > > 1. Pending writes from Skia are flushed > 2. Chromium writes to the texture without involving Skia > 3. Chromium requests a readback of the texture using Skia > 4. Skia reads back the texture > > instead of > > 1. Chromium writes to the texture without involving Skia > 2. Chromium requests a readback of the texture using Skia > 3. Pending writes from Skia are flushed > 4. Skia reads back the texture > > BUG=504773, 499555 > TEST=WebGL conformance tests > > Committed: https://crrev.com/140faf7e1dbc0f41a57242b4d3114bad6b9552fd > Cr-Commit-Position: refs/heads/master@{#338089} TBR=dalecurtis@chromium.org,qinmin@chromium.org,bsalomon@google.com,xhwang@chromium.org,oetuaho@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504773, 499555 Committed: https://crrev.com/2ba7d980f4febe513782ef8ffa69df1a604ba0b7 Cr-Commit-Position: refs/heads/master@{#338165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M media/blink/skcanvas_video_renderer.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Flush pending writes on Skia scratch textures used in Chromium
5 years, 5 months ago (2015-07-09 22:20:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226093008/1
5 years, 5 months ago (2015-07-09 22:22:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-09 22:25:42 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 22:27:59 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ba7d980f4febe513782ef8ffa69df1a604ba0b7
Cr-Commit-Position: refs/heads/master@{#338165}

Powered by Google App Engine
This is Rietveld 408576698