Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Issue 1226093005: Give ProfileChooserView signin button focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
index 22ec640e2c9d9449ec6fe870128824935e71355b..a84fe9a504045e127307d3df8e3fe18a6736dff1 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
@@ -168,6 +168,11 @@ class ProfileChooserViewExtensionsTest : public ExtensionBrowserTest {
return ProfileChooserView::profile_bubble_;
}
+ views::View* signin_current_profile_link() {
+ DCHECK(ProfileChooserView::profile_bubble_);
+ return ProfileChooserView::profile_bubble_->signin_current_profile_link_;
+ }
+
void ShowSigninView() {
DCHECK(current_profile_bubble());
DCHECK(current_profile_bubble()->avatar_menu_);
@@ -183,6 +188,14 @@ class ProfileChooserViewExtensionsTest : public ExtensionBrowserTest {
DISALLOW_COPY_AND_ASSIGN(ProfileChooserViewExtensionsTest);
};
+// crbug.com/449088
msw 2015/07/13 20:06:22 nit: I don't think this comment is helpful, ditto
wjmaclean 2015/07/13 21:11:40 While I address the other comment, can you elabora
msw 2015/07/13 21:37:29 The test name and code are sufficiently straightfo
+IN_PROC_BROWSER_TEST_F(ProfileChooserViewExtensionsTest, SigninButtonHasFocus) {
+ ASSERT_TRUE(profiles::IsMultipleProfilesEnabled());
+ ASSERT_NO_FATAL_FAILURE(OpenProfileChooserView(browser()));
+
+ EXPECT_TRUE(signin_current_profile_link()->HasFocus());
+}
+
// crbug.com/502370
IN_PROC_BROWSER_TEST_F(ProfileChooserViewExtensionsTest, ContentAreaHasFocus) {
ASSERT_TRUE(profiles::IsMultipleProfilesEnabled());

Powered by Google App Engine
This is Rietveld 408576698