Give ProfileChooserView signin button focus.

chrome/browser/ui/views/profiles/profile_chooser_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/profile_chooser_view.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
@@ skipping 490 matching lines @@
       profile_bubble_->ShowView(view_mode, profile_bubble_->avatar_menu_.get());
     }
     return;
   }
 
   profile_bubble_ = new ProfileChooserView(anchor_view, arrow, browser,
       view_mode, tutorial_mode, manage_accounts_params.service_type);
   views::BubbleDelegateView::CreateBubble(profile_bubble_);
   profile_bubble_->set_close_on_deactivate(close_on_deactivate_for_testing_);
   profile_bubble_->SetAlignment(border_alignment);
+  profile_bubble_->initially_focused_view_ =

[msw, 2015/07/13 21:37:30]

Why is this controlled here? Let ProfileChooserView::GetInitiallyFocusedView
return |signin_current_profile_link_| directly and eliminate
|initially_focused_view_|. (ProfileChooserView knows the |view_mode| and is a
more appropriate user of its |signin_current_profile_link_| member)

[wjmaclean, 2015/07/14 12:26:18]

Done.

+      (view_mode == profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER)

[msw, 2015/07/13 21:37:30]

I don't think there's a need for this conditional behavior; if
|ProfileChooserView::signin_current_profile_link_| is null, then this is
effectively the same thing, and I think that the behavior may work even if it
isn't null and the view isn't part of the current hierarchy.

[wjmaclean, 2015/07/14 12:26:18]

Done.

+          ? profile_bubble_->signin_current_profile_link_
+          : nullptr;
+  profile_bubble_->GetWidget()->set_focus_on_creation(true);

[msw, 2015/07/13 21:37:30]

Why is this needed? The button should be focused on Show() below without this.

[wjmaclean, 2015/07/14 12:26:18]

Done.

   profile_bubble_->GetWidget()->Show();
   profile_bubble_->SetArrowPaintType(views::BubbleBorder::PAINT_NONE);
 }
 
 // static
 bool ProfileChooserView::IsShowing() {
   return profile_bubble_ != NULL;
 }
 
 // static
@@ skipping 15 matching lines @@
 }
 
 ProfileChooserView::ProfileChooserView(views::View* anchor_view,
                                        views::BubbleBorder::Arrow arrow,
                                        Browser* browser,
                                        profiles::BubbleViewMode view_mode,
                                        profiles::TutorialMode tutorial_mode,
                                        signin::GAIAServiceType service_type)
     : BubbleDelegateView(anchor_view, arrow),
       browser_(browser),
+      initially_focused_view_(nullptr),
       view_mode_(view_mode),
       tutorial_mode_(tutorial_mode),
       gaia_service_type_(service_type) {
   // Reset the default margins inherited from the BubbleDelegateView.
   // Add a small bottom inset so that the bubble's rounded corners show up.
   set_margins(gfx::Insets(0, 0, 1, 0));
   set_background(views::Background::CreateSolidBackground(
       GetNativeTheme()->GetSystemColor(
           ui::NativeTheme::kColorId_DialogBackground)));
   ResetView();
@@ skipping 174 matching lines @@
 bool ProfileChooserView::AcceleratorPressed(
     const ui::Accelerator& accelerator) {
   if (accelerator.key_code() != ui::VKEY_DOWN &&
       accelerator.key_code() != ui::VKEY_UP)
     return BubbleDelegateView::AcceleratorPressed(accelerator);
   // Move the focus up or down.
   GetFocusManager()->AdvanceFocus(accelerator.key_code() != ui::VKEY_DOWN);
   return true;
 }
 
+views::View* ProfileChooserView::GetInitiallyFocusedView() {
+  return initially_focused_view_;
+}
+
 bool ProfileChooserView::HandleContextMenu(
     const content::ContextMenuParams& params) {
   // Suppresses the context menu because some features, such as inspecting
   // elements, are not appropriate in a bubble.
   return true;
 }
 
 void ProfileChooserView::ButtonPressed(views::Button* sender,
                                        const ui::Event& event) {
   if (sender == users_button_) {
@@ skipping 998 matching lines @@
       IncognitoModePrefs::GetAvailability(browser_->profile()->GetPrefs()) !=
           IncognitoModePrefs::DISABLED;
   return incognito_available && !browser_->profile()->IsGuestSession();
 }
 
 void ProfileChooserView::PostActionPerformed(
     ProfileMetrics::ProfileDesktopMenu action_performed) {
   ProfileMetrics::LogProfileDesktopMenu(action_performed, gaia_service_type_);
   gaia_service_type_ = signin::GAIA_SERVICE_TYPE_NONE;
 }