Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1226083005: Introduce UMA metrics for path MTU discovery. (Closed)

Created:
5 years, 5 months ago by Victor Vasiliev (old)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce UMA metrics for path MTU discovery. R=rch@chromium.org Committed: https://crrev.com/852748e35a26646b62cbf6cb985205c384fc2eb1 Cr-Commit-Position: refs/heads/master@{#338938}

Patch Set 1 #

Patch Set 2 : Same, but without independant net-log change #

Total comments: 6

Patch Set 3 : Replace last histogram with UMA_HISTOGRAM_COUNTS #

Patch Set 4 : Add a comment explaining the choice of the histogram. #

Total comments: 6

Patch Set 5 : Clarify the descriptions of UMA metrics introduced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M net/quic/quic_client_session.cc View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
Victor Vasiliev (old)
5 years, 5 months ago (2015-07-09 17:15:41 UTC) #1
Ryan Hamilton
lgtm. You'll need to get asvitkine to approve the histograms change. https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_connection.h File net/quic/quic_connection.h (right): ...
5 years, 5 months ago (2015-07-14 16:37:12 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc#newcode314 net/quic/quic_client_session.cc:314: connection()->mtu_probe_count()); Sparse histograms are generally not a good choice ...
5 years, 5 months ago (2015-07-14 16:55:10 UTC) #4
Victor Vasiliev (old)
5 years, 5 months ago (2015-07-14 18:30:45 UTC) #5
Victor Vasiliev (old)
https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc#newcode314 net/quic/quic_client_session.cc:314: connection()->mtu_probe_count()); On 2015/07/14 16:55:10, Alexei Svitkine wrote: > Sparse ...
5 years, 5 months ago (2015-07-14 18:31:07 UTC) #6
Alexei Svitkine (slow)
https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc#newcode314 net/quic/quic_client_session.cc:314: connection()->mtu_probe_count()); On 2015/07/14 18:31:07, Victor Vasiliev wrote: > On ...
5 years, 5 months ago (2015-07-14 18:32:54 UTC) #7
Victor Vasiliev (old)
https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc File net/quic/quic_client_session.cc (right): https://codereview.chromium.org/1226083005/diff/20001/net/quic/quic_client_session.cc#newcode314 net/quic/quic_client_session.cc:314: connection()->mtu_probe_count()); On 2015/07/14 18:32:54, Alexei Svitkine wrote: > On ...
5 years, 5 months ago (2015-07-14 18:52:31 UTC) #8
Alexei Svitkine (slow)
lgtm % nits https://codereview.chromium.org/1226083005/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1226083005/diff/60001/tools/metrics/histograms/histograms.xml#newcode22088 tools/metrics/histograms/histograms.xml:22088: + The last MTU used by ...
5 years, 5 months ago (2015-07-14 18:54:45 UTC) #9
Victor Vasiliev (old)
https://codereview.chromium.org/1226083005/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1226083005/diff/60001/tools/metrics/histograms/histograms.xml#newcode22088 tools/metrics/histograms/histograms.xml:22088: + The last MTU used by the client before ...
5 years, 5 months ago (2015-07-14 19:08:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226083005/40002
5 years, 5 months ago (2015-07-15 18:30:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years, 5 months ago (2015-07-15 20:34:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1226083005/40002
5 years, 5 months ago (2015-07-15 21:47:16 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:40002)
5 years, 5 months ago (2015-07-15 22:28:37 UTC) #18
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 22:30:58 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/852748e35a26646b62cbf6cb985205c384fc2eb1
Cr-Commit-Position: refs/heads/master@{#338938}

Powered by Google App Engine
This is Rietveld 408576698