go/src/infra/gae/libs/gae/dummy/dummy.infra_testing - Issue 1226063003: Move dummy service implementations into their own package.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: go/src/infra/gae/libs/gae/dummy/dummy.infra_testing

Issue 1226063003: Move dummy service implementations into their own package. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@abstract

Patch Set: move mathrand test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« go/src/infra/gae/libs/gae/dummy/dummy.go ('K') | « go/src/infra/gae/libs/gae/dummy/dummy.go ('k') | go/src/infra/gae/libs/gae/dummy/dummy_test.go » ('j') | go/src/infra/gae/libs/gae/dummy/dummy_test.go » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "expected_coverage_min": 29,
	estaab 2015/07/13 18:26:35 Is this json or can we include comments? It would Is this json or can we include comments? It would be nice to have a few words justifying lower coverage if possible. iannucci 2015/07/14 01:35:53 It's json. If you look at the html output, it's pr Show quoted text On 2015/07/13 18:26:35, estaab wrote: > Is this json or can we include comments? It would be nice to have a few words > justifying lower coverage if possible. It's json. If you look at the html output, it's pretty obvious why it's not close to 100% (basically, I didn't feel like copy+pasting a test method for every single method, which are all exactly the same). Having tunable coverage annotations would be great here.
	3 "expected_coverage_max": 30

	4 }

	5

OLD	NEW