Chromium Code Reviews| Index: runtime/vm/code_patcher.h |
| =================================================================== |
| --- runtime/vm/code_patcher.h (revision 18597) |
| +++ runtime/vm/code_patcher.h (working copy) |
| @@ -25,10 +25,14 @@ |
| // Dart static calls have a distinct, machine-dependent code pattern. |
| // Patch static call to the new target. |
| - static void PatchStaticCallAt(uword addr, uword new_target_address); |
| + static void PatchStaticCallAt(uword return_address, |
| + const Code& code, |
|
srdjan
2013/02/15 21:24:27
Please modify comment/variable name 'code' to expl
regis
2013/02/15 22:51:31
Done.
|
| + uword new_target_address); |
| // Patch instance call to the new target. |
| - static void PatchInstanceCallAt(uword addr, uword new_target_address); |
| + static void PatchInstanceCallAt(uword return_address, |
| + const Code& code, |
|
srdjan
2013/02/15 21:24:27
ditto here and below.
regis
2013/02/15 22:51:31
Done.
|
| + uword new_target_address); |
| // Patch entry point with a jump as specified in the code's patch region. |
| static void PatchEntry(const Code& code); |
| @@ -40,16 +44,13 @@ |
| // that there are no conflicts with object pointers). Used in ASSERTs. |
| static bool CodeIsPatchable(const Code& code); |
| - // Returns true if the code before return_address is a static |
| - // or dynamic Dart call. |
| - static bool IsDartCall(uword return_address); |
| + static uword GetStaticCallTargetAt(uword return_address, const Code& code); |
| - static uword GetStaticCallTargetAt(uword return_address); |
| - |
| // Get instance call information. Returns the call target and sets each |
| // of the output parameters ic_data and arguments_descriptor if they are |
| // non-NULL. |
| static uword GetInstanceCallAt(uword return_address, |
| + const Code& code, |
| ICData* ic_data, |
| Array* arguments_descriptor); |