Add support for object pool

runtime/vm/assembler_arm.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_ARM_H_
 #define VM_ASSEMBLER_ARM_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_arm.h directly; use assembler.h instead.
 #endif
@@ skipping 246 matching lines @@
     Address::operator=(other);
     return *this;
   }
 };
 
 
 class Assembler : public ValueObject {
  public:
   Assembler()
       : buffer_(),
-        object_pool_(GrowableObjectArray::Handle(GrowableObjectArray::New())),
+        object_pool_(GrowableObjectArray::Handle()),
         prologue_offset_(-1),
         comments_() { }
   ~Assembler() { }
 
   void PopRegister(Register r) { Pop(r); }
 
   void Bind(Label* label);
 
   // Misc. functionality
   int CodeSize() const { return buffer_.Size(); }
   int prologue_offset() const { return prologue_offset_; }
   const ZoneGrowableArray<int>& GetPointerOffsets() const {
     ASSERT(buffer_.pointer_offsets().length() == 0);  // No pointers in code.
     return buffer_.pointer_offsets();
   }
-  const GrowableObjectArray& object_pool() const {
-    return object_pool_;
-  }
+  const GrowableObjectArray& object_pool() const { return object_pool_; }
 
   void FinalizeInstructions(const MemoryRegion& region) {
     buffer_.FinalizeInstructions(region);
-    ASSERT(object_pool_.Length() == 0);  // TODO(regis): Otherwise, more work.
   }
 
   // Debugging and bringup support.
   void Stop(const char* message);
   void Unimplemented(const char* message);
   void Untested(const char* message);
   void Unreachable(const char* message);
 
   static void InitializeMemoryWithBreakpoints(uword data, int length);
 
@@ skipping 152 matching lines @@
   void vcmpsz(SRegister sd, Condition cond = AL);
   void vcmpdz(DRegister dd, Condition cond = AL);
   void vmstat(Condition cond = AL);  // VMRS APSR_nzcv, FPSCR
 
   // Branch instructions.
   void b(Label* label, Condition cond = AL);
   void bl(Label* label, Condition cond = AL);
   void blx(Register rm, Condition cond = AL);
 
   // Macros.
-  // Branch to an entry address that can be patched at runtime.
+  // Branch to an entry address. Call sequence is never patched.
   void Branch(const ExternalLabel* label);
+
+  // Branch and link to an entry address. Call sequence is never patched.
   void BranchLink(const ExternalLabel* label);
 
-  // Branch to entry after setting LR and storing LR at ad.
+  // Branch and link to an entry address. Call sequence can be patched.
+  void BranchLinkPatchable(const ExternalLabel* label);
+
+  // Branch and link to entry after storing return address at ad.
+  // Call sequence is never patched.
   void BranchLinkStore(const ExternalLabel* label, Address ad);
 
-  // Branch to [base + offset] after setting LR.
+  // Branch and link to [base + offset]. Call sequence is never patched.
   void BranchLinkOffset(Register base, int offset);
 
   // Add signed constant value to rd. May clobber IP.
   void AddConstant(Register rd, int32_t value, Condition cond = AL);
   void AddConstant(Register rd, Register rn, int32_t value,
                    Condition cond = AL);
   void AddConstantSetFlags(Register rd, Register rn, int32_t value,
                            Condition cond = AL);
   void AddConstantWithCarry(Register rd, Register rn, int32_t value,
                             Condition cond = AL);
@@ skipping 46 matching lines @@
   void Lsr(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);
   void Asr(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);
   void Ror(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);
   void Rrx(Register rd, Register rm, Condition cond = AL);
 
   // Emit data (e.g encoded instruction or immediate) in instruction stream.
   void Emit(int32_t value);
 
  private:
   AssemblerBuffer buffer_;  // Contains position independent code.
-  const GrowableObjectArray& object_pool_;  // Objects and jump targets.
+  GrowableObjectArray& object_pool_;  // Objects and patchable jump targets.
   int32_t prologue_offset_;
 
   int32_t AddObject(const Object& obj);
   int32_t AddExternalLabel(const ExternalLabel* label);
 
   class CodeComment : public ZoneAllocated {
    public:
     CodeComment(intptr_t pc_offset, const String& comment)
         : pc_offset_(pc_offset), comment_(comment) { }
 
@@ skipping 88 matching lines @@
     return *reg1 - *reg2;
   }
 
   DISALLOW_ALLOCATION();
   DISALLOW_COPY_AND_ASSIGN(Assembler);
 };
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_ARM_H_