Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Issue 12260020: [Telemetry] Fix tab list updating with connected tabs. (Closed)

Created:
7 years, 10 months ago by dtu
Modified:
7 years, 10 months ago
Reviewers:
nduca, hartmanng
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix tab list updating with connected tabs. When you connect to a tab's websocket, Chrome no longer reports a websocketDebuggerUrl. TabListBackend wasn't treating this case correctly, causing its tab list to have "None" tabs, which led to all sorts of fun corruption. BUG=166243, 174922 TEST=Unit test included. ./run_tests testMultipleTabs Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182341

Patch Set 1 #

Patch Set 2 : New unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M tools/telemetry/telemetry/browser_unittest.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/tab_list_backend.py View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dtu
7 years, 10 months ago (2013-02-13 22:42:22 UTC) #1
hartmanng
tab_list_backend.py LGTM, could you explain the unit test though? It seems a bit indirect, would ...
7 years, 10 months ago (2013-02-13 23:19:57 UTC) #2
dtu
I've replaced the unit test with a slightly more straightforward one. Yes, the key thing ...
7 years, 10 months ago (2013-02-13 23:45:41 UTC) #3
hartmanng
7 years, 10 months ago (2013-02-13 23:49:37 UTC) #4
ah thanks, LGTM

Powered by Google App Engine
This is Rietveld 408576698