Issue 12260004: Fix verify heap problem when parallel sweeping is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12260004: Fix verify heap problem when parallel sweeping is enabled. (Closed)

Created:
7 years, 10 months ago by Hannes Payer (out of office)

Modified:
7 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix verify heap problem when parallel sweeping is enabled. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13651

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	src/mark-compact.cc	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with one comment. https://codereview.chromium.org/12260004/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/12260004/diff/2001/src/mark-compact.cc#newcode3846 src/mark-compact.cc:3846: if (AreSweeperThreadsActivated()) how_to_sweep = PARALLEL_CONSERVATIVE; ...

7 years, 10 months ago (2013-02-13 10:59:23 UTC) #2

Hannes Payer (out of office)

7 years, 10 months ago (2013-02-13 11:02:26 UTC) #3

https://chromiumcodereview.appspot.com/12260004/diff/2001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/12260004/diff/2001/src/mark-compact.cc...
src/mark-compact.cc:3846: if (AreSweeperThreadsActivated()) how_to_sweep =
PARALLEL_CONSERVATIVE;
On 2013/02/13 10:59:23, Michael Starzinger wrote:
> I think this needs to go up one more line (to above the expose-gc hack),
> otherwise WebKit tests will not run through with concurrent sweeping enabled.

Done.

Expand Messages | Collapse Messages

Issue 12260004: Fix verify heap problem when parallel sweeping is enabled. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages