Issue 12260003: Implemented lazy portal detection.

Issue 12260003: Implemented lazy portal detection. (Closed)

Created:
7 years, 10 months ago by ygorshenin1

Modified:
7 years, 10 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, cbentzel+watch_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implemented lazy portal detection. BUG=169783, 166973, 174061 TEST=unit_tests:NetworkPortalDetectorTest* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182249

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -16 lines)			Patch
M	chrome/browser/chromeos/net/network_portal_detector.h	View		4 chunks	+24 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector.cc	View	1	10 chunks	+70 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/net/network_portal_detector_unittest.cc	View		3 chunks	+93 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View		3 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm https://codereview.chromium.org/12260003/diff/1/chrome/browser/chromeos/net/network_portal_detector.cc File chrome/browser/chromeos/net/network_portal_detector.cc (right): https://codereview.chromium.org/12260003/diff/1/chrome/browser/chromeos/net/network_portal_detector.cc#newcode324 chrome/browser/chromeos/net/network_portal_detector.cc:324: detection_task_.Cancel(); nit: Alignment.

7 years, 10 months ago (2013-02-13 15:12:20 UTC) #2

Nikita (slow)

https://codereview.chromium.org/12260003/diff/1/chrome/browser/chromeos/net/network_portal_detector.cc File chrome/browser/chromeos/net/network_portal_detector.cc (right): https://codereview.chromium.org/12260003/diff/1/chrome/browser/chromeos/net/network_portal_detector.cc#newcode324 chrome/browser/chromeos/net/network_portal_detector.cc:324: detection_task_.Cancel(); On 2013/02/13 15:12:20, Nikita Kostylev wrote: > nit: ...

7 years, 10 months ago (2013-02-13 17:26:31 UTC) #3

Nikita (slow)

7 years, 10 months ago (2013-02-13 17:28:13 UTC) #4

Message was sent while issue was closed.

Committed manually as r182249 (presubmit successful).

Expand Messages | Collapse Messages