Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: content/renderer/context_menu_params_builder.cc

Issue 1225983003: Clean up the interface to DeserializeSecurityInfo, fix uninitialized memory use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/context_menu_params_builder.cc
diff --git a/content/renderer/context_menu_params_builder.cc b/content/renderer/context_menu_params_builder.cc
index 74211f546753003d7bcdebef551cd550cfb9c465..b1944940bd93035e517361a1a4c1c69a8f152c42 100644
--- a/content/renderer/context_menu_params_builder.cc
+++ b/content/renderer/context_menu_params_builder.cc
@@ -77,13 +77,8 @@ ContextMenuParams ContextMenuParamsBuilder::Build(
}
// Deserialize the SSL info.
- if (!data.securityInfo.isEmpty()) {
- DeserializeSecurityInfo(data.securityInfo,
- &params.security_info.cert_id, &params.security_info.cert_status,
- &params.security_info.security_bits,
- &params.security_info.connection_status,
- &params.security_info.signed_certificate_timestamp_ids);
- }
+ if (!data.securityInfo.isEmpty())
+ params.security_info = DeserializeSecurityInfo(data.securityInfo);
return params;
}

Powered by Google App Engine
This is Rietveld 408576698