runtime/vm/assembler_x64.h - Issue 1225933002: Remove fixed contant pool entries by caching some global constants in Thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_x64.h

Issue 1225933002: Remove fixed contant pool entries by caching some global constants in Thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: addressed comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_x64.h

diff --git a/runtime/vm/assembler_x64.h b/runtime/vm/assembler_x64.h

index a0bfe26bef8004b45419f860aa705df33a20ba38..327f9768a7243b93fe48203407940f0d4c0d74a4 100644

--- a/runtime/vm/assembler_x64.h

+++ b/runtime/vm/assembler_x64.h

@@ -1066,7 +1066,7 @@ class Assembler : public ValueObject {

bool allow_constant_pool_;

intptr_t FindImmediate(int64_t imm);

- bool CanLoadFromObjectPool(const Object& object);

+ bool CanLoadFromObjectPool(const Object& object) const;

void LoadWordFromPoolOffset(Register dst, Register pp, int32_t offset);

inline void EmitUint8(uint8_t value);

« no previous file with comments | « runtime/vm/assembler_arm64_test.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/thread.cc » ('J')