Refugee from Dead Machine 4: MDB Monster

src/gpu/GrDrawingManager.cpp

 /*
  * Copyright 2015 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
+#define ENABLE_MDB 1
+
 #include "GrAtlasTextContext.h"
 #include "GrDrawContext.h"
 #include "GrDrawingManager.h"
 #include "GrDrawTarget.h"
 #include "GrResourceProvider.h"
 #include "GrSoftwarePathRenderer.h"
 #include "GrStencilAndCoverTextContext.h"
 #include "SkTTopoSort.h"
 
-//#define ENABLE_MDB 1
-
 void GrDrawingManager::cleanup() {
     for (int i = 0; i < fDrawTargets.count(); ++i) {
+        fDrawTargets[i]->makeClosed();  // no drawTarget should receive a new command after this
+        fDrawTargets[i]->clearRT();
         fDrawTargets[i]->unref();
     }
 
     fDrawTargets.reset();
 
     delete fNVPRTextContext;
     fNVPRTextContext = nullptr;
 
     for (int i = 0; i < kNumPixelGeometries; ++i) {
         delete fTextContexts[i][0];
@@ skipping 36 matching lines @@
     SkASSERT(result);
 
 #if 0
     for (int i = 0; i < fDrawTargets.count(); ++i) {
         SkDEBUGCODE(fDrawTargets[i]->dump();)
     }
 #endif
 
     for (int i = 0; i < fDrawTargets.count(); ++i) {
         fDrawTargets[i]->prepareBatches(&fFlushState);
+        // this causes an assert to fire
+//        fDrawTargets[i]->unref();
     }
 
     // Upload all data to the GPU
     fFlushState.preIssueDraws();
 
     for (int i = 0; i < fDrawTargets.count(); ++i) {
         fDrawTargets[i]->drawBatches(&fFlushState);
     }
 
-    SkASSERT(fFlushState.lastFlushedToken() == fFlushState.currentToken());
+    SkASSERT(fFlushState.lastFlushedToken() == fFlushState.currentToken2());
 
 #ifndef ENABLE_MDB
     // When MDB is disabled we keep reusing the same drawTarget
     if (fDrawTargets.count()) {
         SkASSERT(fDrawTargets.count() == 1);
         fDrawTargets[0]->resetFlag(GrDrawTarget::kWasOutput_Flag);
     }
 #endif
 
     for (int i = 0; i < fDrawTargets.count(); ++i) {
         fDrawTargets[i]->reset();
     }
     fFlushState.reset();
+    fDrawTargets.reset();
 }
 
 GrTextContext* GrDrawingManager::textContext(const SkSurfaceProps& props,
                                              GrRenderTarget* rt) {
     if (this->abandoned()) {
         return nullptr;
     }
 
     SkASSERT(props.pixelGeometry() < kNumPixelGeometries);
     bool useDIF = props.isUseDeviceIndependentFonts();
@@ skipping 64 matching lines @@
 }
 
 GrDrawContext* GrDrawingManager::drawContext(GrRenderTarget* rt,
                                              const SkSurfaceProps* surfaceProps) {
     if (this->abandoned()) {
         return nullptr;
     }
 
     return new GrDrawContext(this, rt, surfaceProps);
 }