Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1225923009: Add dart:sky.internals and dart:sky_builtin_natives to Sky sdk_ext (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add dart:sky.internals and dart:sky_builtin_natives to Sky sdk_ext BUG= R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/97804c4fe25bbbaa86a27614ca3d8ba5e674b38f

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M mojo/public/dart/rules.gni View 1 3 chunks +10 lines, -1 line 0 comments Download
M mojo/public/tools/dart_pkg.py View 2 chunks +10 lines, -0 lines 0 comments Download
M sky/sdk/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M sky/sdk/lib/.sdkext View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 5 months ago (2015-07-08 18:28:09 UTC) #2
eseidel
lgtm
5 years, 5 months ago (2015-07-08 19:08:14 UTC) #4
Cutch
5 years, 5 months ago (2015-07-08 19:08:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
97804c4fe25bbbaa86a27614ca3d8ba5e674b38f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698