Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1225923003: Make compression optional in TraceUploader. (Closed)

Created:
5 years, 5 months ago by shatch
Modified:
5 years, 5 months ago
Reviewers:
dsinclair, davidben
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make compression optional in TraceUploader. In many instances the trace data is already compressed, and the TraceCrashServiceUploader is compressing it again. BUG=504862 Committed: https://crrev.com/c93f6b8c13f493a54bdace70b66b643981b81043 Cr-Commit-Position: refs/heads/master@{#337828}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Use enum. #

Total comments: 2

Patch Set 3 : Pass enum. #

Total comments: 2

Patch Set 4 : Added comment for clarification. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -21 lines) Patch
M chrome/browser/tracing/background_tracing_field_trial.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tracing/crash_service_uploader.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/tracing/crash_service_uploader.cc View 1 3 chunks +22 lines, -10 lines 0 comments Download
M chrome/browser/tracing/navigation_tracing.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_ui.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tracing/tracing_ui.cc View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download
M content/public/browser/trace_uploader.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
shatch
5 years, 5 months ago (2015-07-07 15:31:07 UTC) #3
dsinclair
https://codereview.chromium.org/1225923003/diff/20001/content/public/browser/trace_uploader.h File content/public/browser/trace_uploader.h (right): https://codereview.chromium.org/1225923003/diff/20001/content/public/browser/trace_uploader.h#newcode30 content/public/browser/trace_uploader.h:30: bool compress_on_upload, Can we switch the bool to an ...
5 years, 5 months ago (2015-07-07 16:42:04 UTC) #4
shatch
https://codereview.chromium.org/1225923003/diff/20001/content/public/browser/trace_uploader.h File content/public/browser/trace_uploader.h (right): https://codereview.chromium.org/1225923003/diff/20001/content/public/browser/trace_uploader.h#newcode30 content/public/browser/trace_uploader.h:30: bool compress_on_upload, On 2015/07/07 16:42:04, dsinclair wrote: > Can ...
5 years, 5 months ago (2015-07-07 18:25:48 UTC) #5
dsinclair
lgtm w/ nit. https://codereview.chromium.org/1225923003/diff/40001/content/browser/tracing/tracing_ui.cc File content/browser/tracing/tracing_ui.cc (right): https://codereview.chromium.org/1225923003/diff/40001/content/browser/tracing/tracing_ui.cc#newcode319 content/browser/tracing/tracing_ui.cc:319: DoUploadInternal(file_contents, false); Can these pass the ...
5 years, 5 months ago (2015-07-07 18:36:37 UTC) #6
shatch
+davidben for content/public/browser/trace_uploader.h https://codereview.chromium.org/1225923003/diff/40001/content/browser/tracing/tracing_ui.cc File content/browser/tracing/tracing_ui.cc (right): https://codereview.chromium.org/1225923003/diff/40001/content/browser/tracing/tracing_ui.cc#newcode319 content/browser/tracing/tracing_ui.cc:319: DoUploadInternal(file_contents, false); On 2015/07/07 18:36:37, dsinclair ...
5 years, 5 months ago (2015-07-07 19:26:00 UTC) #8
davidben
https://codereview.chromium.org/1225923003/diff/20002/content/browser/tracing/tracing_ui.cc File content/browser/tracing/tracing_ui.cc (right): https://codereview.chromium.org/1225923003/diff/20002/content/browser/tracing/tracing_ui.cc#newcode319 content/browser/tracing/tracing_ui.cc:319: DoUploadInternal(file_contents, TraceUploader::UNCOMPRESSED_UPLOAD); It's not obvious from reading this why ...
5 years, 5 months ago (2015-07-07 23:35:25 UTC) #9
shatch
https://codereview.chromium.org/1225923003/diff/20002/content/browser/tracing/tracing_ui.cc File content/browser/tracing/tracing_ui.cc (right): https://codereview.chromium.org/1225923003/diff/20002/content/browser/tracing/tracing_ui.cc#newcode319 content/browser/tracing/tracing_ui.cc:319: DoUploadInternal(file_contents, TraceUploader::UNCOMPRESSED_UPLOAD); On 2015/07/07 23:35:25, David Benjamin wrote: > ...
5 years, 5 months ago (2015-07-08 14:04:11 UTC) #10
davidben
lgtm
5 years, 5 months ago (2015-07-08 16:02:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225923003/70001
5 years, 5 months ago (2015-07-08 16:03:53 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:70001)
5 years, 5 months ago (2015-07-08 16:09:15 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 16:10:08 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c93f6b8c13f493a54bdace70b66b643981b81043
Cr-Commit-Position: refs/heads/master@{#337828}

Powered by Google App Engine
This is Rietveld 408576698