Linux: apply a different hyphen patch.

webkit/support/test_webkit_platform_support.cc

Index: webkit/support/test_webkit_platform_support.cc
diff --git a/webkit/support/test_webkit_platform_support.cc b/webkit/support/test_webkit_platform_support.cc
index e9f1961ed98c59416a21d21013cb963ab761113f..3146870271d496ad62ace86c349cce71abba1ea7 100644
--- a/webkit/support/test_webkit_platform_support.cc
+++ b/webkit/support/test_webkit_platform_support.cc
@@ -549,12 +549,7 @@ size_t TestWebKitPlatformSupport::computeLastHyphenLocation(
     // flakiness, this code synchronously loads the dictionary.
     base::FilePath path = webkit_support::GetChromiumRootDirFilePath();
     path = path.Append(FILE_PATH_LITERAL("third_party/hyphen/hyph_en_US.dic"));
-    std::string dictionary;
-    if (!file_util::ReadFileToString(path, &dictionary))
-      return 0;
-    hyphen_dictionary_ = hnj_hyphen_load(
-        reinterpret_cast<const unsigned char*>(dictionary.data()),
-        dictionary.length());
+    hyphen_dictionary_ = hnj_hyphen_load(path.value().c_str());

[darin (slow to review), 2013/02/15 18:16:40]

Does this work on Windows?  FilePath::value() returns wstring on Windows.  It
looks like hnj_hyphen_load expects a |const char*|.  You should probably use the
FdopenPlatformFile approach here as well to avoid Unicode issues.  Don't try to
pass UTF-8 to fopen on Windows.  It won't always work.

[Paweł Hajdan Jr., 2013/02/19 13:00:12]

Fixed. Thank you for advice about Windows quirks.

     if (!hyphen_dictionary_)
       return 0;
   }