Linux: apply a different hyphen patch.

base/platform_file_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/platform_file.h"
 
+#include <io.h>
+
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/threading/thread_restrictions.h"
 
 namespace base {
 PlatformFile CreatePlatformFileUnsafe(const FilePath& name,
                                       int flags,
                                       bool* created,
                                       PlatformFileError* error) {
   base::ThreadRestrictions::AssertIOAllowed();
@@ skipping 85 matching lines @@
           break;
         default:
           *error = PLATFORM_FILE_ERROR_FAILED;
       }
     }
   }
 
   return file;
 }
 
+FILE* FdopenPlatformFile(PlatformFile file, const char* mode) {
+  if (file == kInvalidPlatformFileValue)

[darin (slow to review), 2013/02/21 04:08:44]

nit: Is it really necessary to add this precondition?  Won't _open_osfhandle
simply fail when passed a invalid handle value?

nit: This function should also have the AssertIOAllowed() check.

[Paweł Hajdan Jr., 2013/02/21 09:14:19]

Good question. It does fail and takes entire process with it.

In Debug it looks like

f:\dd\vctools\crt_bld\self_x86\crt\src\fdopen.c(55) : Assertion failed: (filedes
>= 0 && (unsigned)filedes < (unsigned)_nhandle)

While the above is about _fdopen and not _open_osfhandle, I prefer not to mess
with surprising (to me) Windows semantics here.
I removed one from POSIX version so I'm not adding one here for consistency.

+    return NULL;
+  int fd = _open_osfhandle(reinterpret_cast<intptr_t>(file), 0);
+  if (fd < 0)
+    return NULL;
+  return _fdopen(fd, mode);
+}
+
 bool ClosePlatformFile(PlatformFile file) {
   base::ThreadRestrictions::AssertIOAllowed();
   return (CloseHandle(file) != 0);
 }
 
 int64 SeekPlatformFile(PlatformFile file,
                        PlatformFileWhence whence,
                        int64 offset) {
   base::ThreadRestrictions::AssertIOAllowed();
   if (file < 0 || offset < 0)
@@ skipping 131 matching lines @@
   info->is_directory =
       (file_info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != 0;
   info->is_symbolic_link = false; // Windows doesn't have symbolic links.
   info->last_modified = base::Time::FromFileTime(file_info.ftLastWriteTime);
   info->last_accessed = base::Time::FromFileTime(file_info.ftLastAccessTime);
   info->creation_time = base::Time::FromFileTime(file_info.ftCreationTime);
   return true;
 }
 
 }  // namespace base