Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 12259018: Provide alternate constructor for specifying a simple thread's stacksize. (Closed)

Created:
7 years, 10 months ago by nfullagar1
Modified:
7 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Provide alternate constructor for specifying a simple thread's stacksize. For Native Client builds, make default stack size 2MB regardless of newlib or glibc. TEST=try bots BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183618

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M ppapi/utility/threading/simple_thread.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/utility/threading/simple_thread.cc View 1 2 3 4 3 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nfullagar1
7 years, 10 months ago (2013-02-14 19:03:17 UTC) #1
brettw
Do you think it makes sense to pick a larger default stack size? If you ...
7 years, 10 months ago (2013-02-15 00:41:13 UTC) #2
nfullagar1
It was a closer shave than originally thought. Default stack size in NaCl for newlib ...
7 years, 10 months ago (2013-02-16 00:15:03 UTC) #3
brettw
https://codereview.chromium.org/12259018/diff/8001/ppapi/utility/threading/simple_thread.h File ppapi/utility/threading/simple_thread.h (right): https://codereview.chromium.org/12259018/diff/8001/ppapi/utility/threading/simple_thread.h#newcode32 ppapi/utility/threading/simple_thread.h:32: explicit SimpleThread(const InstanceHandle& instance, const size_t stacksize); I'd remove ...
7 years, 10 months ago (2013-02-16 04:19:40 UTC) #4
nfullagar1
ptal, thx https://codereview.chromium.org/12259018/diff/8001/ppapi/utility/threading/simple_thread.h File ppapi/utility/threading/simple_thread.h (right): https://codereview.chromium.org/12259018/diff/8001/ppapi/utility/threading/simple_thread.h#newcode32 ppapi/utility/threading/simple_thread.h:32: explicit SimpleThread(const InstanceHandle& instance, const size_t stacksize); ...
7 years, 10 months ago (2013-02-19 18:59:10 UTC) #5
brettw
lgtm
7 years, 10 months ago (2013-02-20 19:05:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@chromium.org/12259018/12001
7 years, 10 months ago (2013-02-20 19:07:35 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-20 21:15:02 UTC) #8
Message was sent while issue was closed.
Change committed as 183618

Powered by Google App Engine
This is Rietveld 408576698