net/spdy/spdy_framer.h - Issue 12259004: Remove SpdyPingControlFrame struct. Useful for SPDY 4 development.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_framer.h

Issue 12259004: Remove SpdyPingControlFrame struct. Useful for SPDY 4 development. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_framer.h

diff --git a/net/spdy/spdy_framer.h b/net/spdy/spdy_framer.h

index 319668edaa239ca9e95b49641f60cadd4469d477..257eea7c64009110e2351f0a827a194c44d5dee5 100644

--- a/net/spdy/spdy_framer.h

+++ b/net/spdy/spdy_framer.h

@@ -390,9 +390,9 @@ class NET_EXPORT_PRIVATE SpdyFramer {

SpdySettingsControlFrame* CreateSettings(const SettingsMap& values) const;

SpdySerializedFrame* SerializeSettings(const SpdySettingsIR& settings) const;

- // Creates an instance of SpdyPingControlFrame. The unique_id is used to

+ // Creates and serializes a PING frame. The unique_id is used to

// identify the ping request/response.

- SpdyPingControlFrame* CreatePingFrame(uint32 unique_id) const;

+ SpdyFrame* CreatePingFrame(uint32 unique_id) const;

SpdySerializedFrame* SerializePing(const SpdyPingIR& ping) const;

// Creates and serializes a GOAWAY frame. The GOAWAY frame is used

« no previous file with comments | « net/spdy/buffered_spdy_framer_spdy3_unittest.cc ('k') | net/spdy/spdy_framer.cc » ('j') | no next file with comments »