Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1225883002: Make SkyDemo.apk start offline (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
eseidel1, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make SkyDemo.apk start offline Offline support isn't complete, but after this CL, SkyDemo.apk is able to start and show some UI offline. R=eseidel@chromium.org, eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a46bc79f10a7062459f4e9ee5eff655af80058ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -296 lines) Patch
M sky/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
D sky/apk/demo/AndroidManifest.xml View 1 chunk +0 lines, -20 lines 0 comments Download
D sky/apk/demo/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D sky/apk/demo/README.md View 1 chunk +0 lines, -6 lines 0 comments Download
D sky/apk/demo/org/domokit/sky/demo/SkyDemoActivity.java View 1 chunk +0 lines, -38 lines 0 comments Download
D sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java View 1 chunk +0 lines, -71 lines 0 comments Download
D sky/apk/demo/res/mipmap-hdpi/ic_launcher.png View Binary file 0 comments Download
D sky/apk/demo/res/mipmap-mdpi/ic_launcher.png View Binary file 0 comments Download
D sky/apk/demo/res/mipmap-xhdpi/ic_launcher.png View Binary file 0 comments Download
D sky/apk/demo/res/mipmap-xxhdpi/ic_launcher.png View Binary file 0 comments Download
D sky/apk/demo/res/mipmap-xxxhdpi/ic_launcher.png View Binary file 0 comments Download
D sky/apk/rules.gni View 1 chunk +0 lines, -75 lines 0 comments Download
A + sky/build/sky_app.gni View 1 chunk +0 lines, -18 lines 0 comments Download
M sky/sdk/example/demo_launcher/BUILD.gn View 1 chunk +8 lines, -2 lines 0 comments Download
A + sky/sdk/example/demo_launcher/apk/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/demo_launcher/apk/BUILD.gn View 2 chunks +1 line, -11 lines 0 comments Download
A + sky/sdk/example/demo_launcher/apk/README.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/demo_launcher/apk/org/domokit/sky/demo/SkyDemoActivity.java View 1 chunk +0 lines, -7 lines 0 comments Download
A + sky/sdk/example/demo_launcher/apk/org/domokit/sky/demo/SkyDemoApplication.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/sdk/example/demo_launcher/apk/res/mipmap-hdpi/ic_launcher.png View Binary file 0 comments Download
A + sky/sdk/example/demo_launcher/apk/res/mipmap-mdpi/ic_launcher.png View Binary file 0 comments Download
A + sky/sdk/example/demo_launcher/apk/res/mipmap-xhdpi/ic_launcher.png View Binary file 0 comments Download
A + sky/sdk/example/demo_launcher/apk/res/mipmap-xxhdpi/ic_launcher.png View Binary file 0 comments Download
A + sky/sdk/example/demo_launcher/apk/res/mipmap-xxxhdpi/ic_launcher.png View Binary file 0 comments Download
M sky/sdk/example/mine_digger/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/example/stocks/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 5 months ago (2015-07-06 23:12:53 UTC) #1
eseidel
lgtm
5 years, 5 months ago (2015-07-06 23:16:36 UTC) #3
abarth-chromium
5 years, 5 months ago (2015-07-06 23:17:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a46bc79f10a7062459f4e9ee5eff655af80058ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698