Added --email to git_cl.py

Added --email to git_cl.py

Passing the email address used to connect to Rietveld on the command
line is useful for testing purposes, in particular with a test server.

BUG=331123
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=244017

[pgervais, 2013-12-30 23:07:09]

See crbug.com/331123 for background info.

[pgervais, 2014-01-08 22:55:15]

On 2013/12/30 23:07:09, pgervais wrote:
> See crbug.com/331123 for background info.

ping to robbie, in case he has forgotten about this CR :-)

[iannucci, 2014-01-09 22:46:42]

https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py#newcode1566
git_cl.py:1566: parser.add_option('--email', default=None,
Hm... what about 'username'? Since git_cl already has --sent-mail, --email might
be confusing.

Though I guess it's --email in upload.py, which is ALSO confusing.... *sigh*

lgtm

[pgervais, 2014-01-09 22:50:55]

a last question, and you're done! (or not)

https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py#newcode1566
git_cl.py:1566: parser.add_option('--email', default=None,
On 2014/01/09 22:46:42, iannucci wrote:
> Hm... what about 'username'? Since git_cl already has --sent-mail, --email
might
> be confusing.
> 
> Though I guess it's --email in upload.py, which is ALSO confusing.... *sigh*
> 
Exactly :-)

It's not too late, I can change the name of this option if you feel that --email
is too confusing. --username seems fine.

[smut, 2014-01-09 22:52:15]

lgtm

[iannucci, 2014-01-09 22:53:05]

On 2014/01/09 22:50:55, pgervais wrote:
> a last question, and you're done! (or not)
> 
> https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py
> File git_cl.py (right):
> 
> https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py#newcode1566
> git_cl.py:1566: parser.add_option('--email', default=None,
> On 2014/01/09 22:46:42, iannucci wrote:
> > Hm... what about 'username'? Since git_cl already has --sent-mail, --email
> might
> > be confusing.
> > 
> > Though I guess it's --email in upload.py, which is ALSO confusing.... *sigh*
> > 
> Exactly :-)
> 
> It's not too late, I can change the name of this option if you feel that
--email
> is too confusing. --username seems fine.

Yeah, but I think it would be equally confusing to have '--username' turn into
'--email' :/

[pgervais, 2014-01-09 22:58:23]

Then I can add the --username option to upload.py :-) [and leave --email
for backward compatibility]


On Thu, Jan 9, 2014 at 2:53 PM, <iannucci@chromium.org> wrote:

> On 2014/01/09 22:50:55, pgervais wrote:
>
>> a last question, and you're done! (or not)
>>
>
>  https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py
>> File git_cl.py (right):
>>
>
>  https://chromiumcodereview.appspot.com/122583003/diff/1/
>> git_cl.py#newcode1566
>> git_cl.py:1566: parser.add_option('--email', default=None,
>> On 2014/01/09 22:46:42, iannucci wrote:
>> > Hm... what about 'username'? Since git_cl already has --sent-mail,
>> --email
>> might
>> > be confusing.
>> >
>> > Though I guess it's --email in upload.py, which is ALSO confusing....
>> *sigh*
>> >
>> Exactly :-)
>>
>
>  It's not too late, I can change the name of this option if you feel that
>>
> --email
>
>> is too confusing. --username seems fine.
>>
>
> Yeah, but I think it would be equally confusing to have '--username' turn
> into
> '--email' :/
>
> https://chromiumcodereview.appspot.com/122583003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[smut, 2014-01-09 23:04:52]

That would achieve levels of confusion previously thought impossible.

On Thu, Jan 9, 2014 at 2:58 PM, Philippe Gervais <pgervais@chromium.org>wrote:

> Then I can add the --username option to upload.py :-) [and leave --email
> for backward compatibility]
>
>
> On Thu, Jan 9, 2014 at 2:53 PM, <iannucci@chromium.org> wrote:
>
>> On 2014/01/09 22:50:55, pgervais wrote:
>>
>>> a last question, and you're done! (or not)
>>>
>>
>>  https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py
>>> File git_cl.py (right):
>>>
>>
>>  https://chromiumcodereview.appspot.com/122583003/diff/1/
>>> git_cl.py#newcode1566
>>> git_cl.py:1566: parser.add_option('--email', default=None,
>>> On 2014/01/09 22:46:42, iannucci wrote:
>>> > Hm... what about 'username'? Since git_cl already has --sent-mail,
>>> --email
>>> might
>>> > be confusing.
>>> >
>>> > Though I guess it's --email in upload.py, which is ALSO confusing....
>>> *sigh*
>>> >
>>> Exactly :-)
>>>
>>
>>  It's not too late, I can change the name of this option if you feel that
>>>
>> --email
>>
>>> is too confusing. --username seems fine.
>>>
>>
>> Yeah, but I think it would be equally confusing to have '--username' turn
>> into
>> '--email' :/
>>
>> https://chromiumcodereview.appspot.com/122583003/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[iannucci, 2014-01-09 23:10:00]

On 2014/01/09 23:04:52, smut wrote:
> That would achieve levels of confusion previously thought impossible.
> 

:D

Well... upload.py is the domain of rietveld. I wouldn't recommend changing it.

I plan to switch the primary authentication scheme to be oauth2 with the new
upload.py anyway...

I would just leave it as '--email' for now.

> On Thu, Jan 9, 2014 at 2:58 PM, Philippe Gervais <pgervais@chromium.org>wrote:
> 
> > Then I can add the --username option to upload.py :-) [and leave --email
> > for backward compatibility]
> >
> >
> > On Thu, Jan 9, 2014 at 2:53 PM, <mailto:iannucci@chromium.org> wrote:
> >
> >> On 2014/01/09 22:50:55, pgervais wrote:
> >>
> >>> a last question, and you're done! (or not)
> >>>
> >>
> >>  https://chromiumcodereview.appspot.com/122583003/diff/1/git_cl.py
> >>> File git_cl.py (right):
> >>>
> >>
> >>  https://chromiumcodereview.appspot.com/122583003/diff/1/
> >>> git_cl.py#newcode1566
> >>> git_cl.py:1566: parser.add_option('--email', default=None,
> >>> On 2014/01/09 22:46:42, iannucci wrote:
> >>> > Hm... what about 'username'? Since git_cl already has --sent-mail,
> >>> --email
> >>> might
> >>> > be confusing.
> >>> >
> >>> > Though I guess it's --email in upload.py, which is ALSO confusing....
> >>> *sigh*
> >>> >
> >>> Exactly :-)
> >>>
> >>
> >>  It's not too late, I can change the name of this option if you feel that
> >>>
> >> --email
> >>
> >>> is too confusing. --username seems fine.
> >>>
> >>
> >> Yeah, but I think it would be equally confusing to have '--username' turn
> >> into
> >> '--email' :/
> >>
> >> https://chromiumcodereview.appspot.com/122583003/
> >>
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[pgervais, 2014-01-09 23:25:36]

On 2014/01/09 23:10:00, iannucci wrote:
> On 2014/01/09 23:04:52, smut wrote:
> > That would achieve levels of confusion previously thought impossible.
> > 
> 
> :D

:-D

> Well... upload.py is the domain of rietveld. I wouldn't recommend changing it.
> 
> I plan to switch the primary authentication scheme to be oauth2 with the new
> upload.py anyway...
> 
> I would just leave it as '--email' for now.
> 
ok, I'm committing then.
Thanks for your input.

[commit-bot: I haz the power, 2014-01-09 23:25:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pgervais@chromium.org/122583003/1

[commit-bot: I haz the power, 2014-01-09 23:27:22]

Change committed as 244017