Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 12258036: Properly handle disabling sync via the google dashboard. (Closed)

Created:
7 years, 10 months ago by Andrew T Wilson (Slow)
Modified:
7 years, 10 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, Raghu Simha, haitaol1, akalin, tim (not reviewing)
Visibility:
Public.

Description

Properly handle disabling sync via the google dashboard. Add SigninManager::ProhibitSignout() that the policy code can use to disable signout. This makes our previous ad-hoc signout prohibition more stable by catching other places where we might sign out (such as cancelling sync during re-auth). Add SigninManager::IsSignoutProhibited() which UI code that wants to show/hide signout UI can call. Restores old behavior where stopping sync via the google dashboard will try to sign out the user. Fixed sync UI to properly display the "Sync is stopped via the google dashboard" message when sync is stopped on desktop platforms. Updated sync settings code to trigger a re-auth flow when the user clicks on "Advanced Sync Setup..." when sync is stopped via the dashboard. BUG=174134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182705

Patch Set 1 #

Patch Set 2 : Skip signout on cros. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -17 lines) Patch
M chrome/browser/policy/user_policy_signin_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/user_policy_signin_service.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/policy/user_policy_signin_service_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/signin/signin_manager.h View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_manager.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_manager_fake.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_manager_fake.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Andrew T Wilson (Slow)
Roger, PTAL at browser/signin, browser/sync, and sync_setup_handler.cc Dan, PTAL at browser_options_handler.cc Joao, PTAL at browser/policy.
7 years, 10 months ago (2013-02-14 18:15:54 UTC) #1
Dan Beam
browser_options_handler.cc lgtm
7 years, 10 months ago (2013-02-14 21:47:54 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm for browser/signin, browser/sync, and sync_setup_handler.cc Once sign out is disabled by policy, we are ...
7 years, 10 months ago (2013-02-14 21:58:34 UTC) #3
Joao da Silva
lgtm
7 years, 10 months ago (2013-02-15 06:38:22 UTC) #4
Andrew T Wilson (Slow)
On 2013/02/14 21:58:34, Roger Tawa wrote: > lgtm for browser/signin, browser/sync, and sync_setup_handler.cc > > ...
7 years, 10 months ago (2013-02-15 09:36:02 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-02-15 09:36:52 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698