Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

Issue 12258023: Fixes bug where chrome hangs in Mac when clicking on Permission link on Extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments addressed Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
index e5640ba8f17abbbd3ba3ddf18f60439e34e920f9..23613108938a277b8fe8831f687054d3278e8196 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
@@ -280,3 +280,27 @@ TEST_F(ExtensionInstallViewControllerTest, OAuthIssues) {
byItem:[outlineView itemAtRow:3]],
base::SysUTF16ToNSString(prompt.GetOAuthIssue(0).description));
}
+
+TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) {
+ chrome::MockExtensionInstallPromptDelegate delegate;
+
+ ExtensionInstallPrompt::Prompt prompt =
+ chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get());
+ std::vector<string16> permissions;
+ permissions.push_back(UTF8ToUTF16("warning 1"));
+ prompt.SetPermissions(permissions);
+
+ scoped_nsobject<ExtensionInstallViewController>
+ controller([[ExtensionInstallViewController alloc]
+ initWithNavigator:browser()
+ delegate:&delegate
+ prompt:prompt]);
+
+ [controller view]; // Force nib load.
+
+ EXPECT_TRUE([controller cancelButton]);
+ EXPECT_FALSE([controller okButton]);
+
+ [controller cancel:nil];
+ EXPECT_EQ(1, delegate.abort_count());
+}
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698