Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

Issue 12258023: Fixes bug where chrome hangs in Mac when clicking on Permission link on Extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments addressed Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
index c23412537e8057915850db5315596d8066535b79..402dcfbc8dc4d8469c559f9fca619aeb10a39ff4 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm
@@ -47,3 +47,27 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, BasicTest) {
// Wait for the window to finish closing.
EXPECT_FALSE([window isVisible]);
}
+
+IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, Permissions) {
+ content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
+ ExtensionInstallPrompt::ShowParams show_params(tab);
+
+ chrome::MockExtensionInstallPromptDelegate delegate;
+ ExtensionInstallPrompt::Prompt prompt =
+ chrome::BuildExtensionPostInstallPermissionsPrompt(extension_);
+
+ ExtensionInstallDialogController* controller =
+ new ExtensionInstallDialogController(show_params,
+ &delegate,
+ prompt);
+
+ scoped_nsobject<NSWindow> window(
+ [[[controller->view_controller() view] window] retain]);
+ EXPECT_TRUE([window isVisible]);
+
+ // Press cancel to close the window
+ [[controller->view_controller() cancelButton] performClick:nil];
+
+ // Wait for the window to finish closing.
+ EXPECT_FALSE([window isVisible]);
+}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698