net/spdy/spdy_framer.cc - Issue 12258006: Minor change in parsing of GOAWAY frames for correctness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_framer.cc

Issue 12258006: Minor change in parsing of GOAWAY frames for correctness. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_framer.cc

diff --git a/net/spdy/spdy_framer.cc b/net/spdy/spdy_framer.cc

index d49b05e4f1ddde30f3b29e5b5897c97b3cc59b2f..b9826f552cb2edfb8a2f355e572a0362e3848fe7 100644

--- a/net/spdy/spdy_framer.cc

+++ b/net/spdy/spdy_framer.cc

@@ -1219,7 +1219,7 @@ size_t SpdyFramer::ProcessControlFramePayload(const char* data, size_t len) {

current_frame_len_);

reader.Seek(GetControlFrameMinimumSize()); // Skip frame header.

SpdyStreamId last_accepted_stream_id = kInvalidStream;

- bool successful_read = reader.ReadUInt32(&last_accepted_stream_id);

+ bool successful_read = reader.ReadUInt31(&last_accepted_stream_id);

DCHECK(successful_read);

SpdyGoAwayStatus status = GOAWAY_OK;

if (spdy_version_ >= 3) {

« no previous file with comments | « no previous file | net/spdy/spdy_framer_test.cc » ('j') | no next file with comments »