Remove SpdyWindowUpdateControlFrame. Useful in SPDY 4 development.

net/spdy/spdy_framer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(rtenhove) clean up frame buffer size calculations so that we aren't
 // constantly adding and subtracting header sizes; this is ugly and error-
 // prone.
 
 #include "net/spdy/spdy_framer.h"
 
@@ skipping 1171 matching lines @@
       DCHECK(!control_frame.has_header_block());
       // Use frame-specific handlers.
       switch (control_frame.type()) {
         case PING: {
             SpdyPingControlFrame* ping_frame =
                 reinterpret_cast<SpdyPingControlFrame*>(&control_frame);
             visitor_->OnPing(ping_frame->unique_id());
           }
           break;
         case WINDOW_UPDATE: {
-            SpdyWindowUpdateControlFrame *window_update_frame =
-                reinterpret_cast<SpdyWindowUpdateControlFrame*>(&control_frame);
-            visitor_->OnWindowUpdate(window_update_frame->stream_id(),
-                                     window_update_frame->delta_window_size());
+            SpdyFrameReader reader(current_frame_buffer_.get(),
+                                   current_frame_len_);
+            reader.Seek(SpdyFrame::kHeaderSize);  // Seek past frame header.
+            SpdyStreamId stream_id = kInvalidStream;
+            uint32 delta_window_size = 0;
+            bool successful_read = reader.ReadUInt31(&stream_id);
+            DCHECK(successful_read);
+            successful_read = reader.ReadUInt32(&delta_window_size);
+            DCHECK(successful_read);
+            DCHECK(reader.IsDoneReading());
+            visitor_->OnWindowUpdate(stream_id, delta_window_size);
           }
           break;
         case RST_STREAM: {
             SpdyRstStreamControlFrame* rst_stream_frame =
                 reinterpret_cast<SpdyRstStreamControlFrame*>(&control_frame);
             visitor_->OnRstStream(rst_stream_frame->stream_id(),
                                   rst_stream_frame->status());
           }
           break;
         case GOAWAY: {
@@ skipping 432 matching lines @@
     builder.WriteUInt16(0);  // Unused.
   }
   DCHECK_EQ(GetHeadersMinimumSize(), builder.length());
 
   SerializeNameValueBlock(&builder, headers);
   DCHECK_EQ(size, builder.length());
 
   return builder.take();
 }
 
-SpdyWindowUpdateControlFrame* SpdyFramer::CreateWindowUpdate(
+SpdyFrame* SpdyFramer::CreateWindowUpdate(
     SpdyStreamId stream_id,
     uint32 delta_window_size) const {
   SpdyWindowUpdateIR window_update(stream_id, delta_window_size);
-  return reinterpret_cast<SpdyWindowUpdateControlFrame*>(
-      SerializeWindowUpdate(window_update));
+  return SerializeWindowUpdate(window_update);
 }
 
 SpdySerializedFrame* SpdyFramer::SerializeWindowUpdate(
     const SpdyWindowUpdateIR& window_update) const {
   SpdyFrameBuilder builder(WINDOW_UPDATE,
                            kNoFlags,
                            protocol_version(),
                            GetWindowUpdateSize());
   builder.WriteUInt32(window_update.stream_id());
   builder.WriteUInt32(window_update.delta());
@@ skipping 396 matching lines @@
       builder->WriteString(it->first);
       builder->WriteString(it->second);
     } else {
       builder->WriteStringPiece32(it->first);
       builder->WriteStringPiece32(it->second);
     }
   }
 }
 
 }  // namespace net