Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: cc/tile_manager.cc

Issue 12258004: [cc] Pass metadata about a tile to the raster system for benchmarks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/tile_manager.h ('K') | « cc/tile_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/tile_manager.cc
diff --git a/cc/tile_manager.cc b/cc/tile_manager.cc
index f4c8bddbd93956b6214476603715d8039b1a0327..01d3cc696d65007f38704c1a505e6b41b2727e7d 100644
--- a/cc/tile_manager.cc
+++ b/cc/tile_manager.cc
@@ -759,6 +759,18 @@ scoped_ptr<ResourcePool::Resource> TileManager::PrepareTileForRaster(
return resource.Pass();
}
+namespace {
reveman 2013/02/13 10:24:39 we already have an anonymous namespace section at
+
+RasterTaskMetadata GetRasterTaskMetadata(const ManagedTileState& mts) {
+ RasterTaskMetadata raster_task_metadata;
+ raster_task_metadata.is_tile_in_pending_tree_now_bin =
+ mts.tree_bin[PENDING_TREE] == NOW_BIN;
+ raster_task_metadata.tile_resolution = mts.resolution;
+ return raster_task_metadata;
+}
+
+} // namespace
+
void TileManager::DispatchOneRasterTask(scoped_refptr<Tile> tile) {
TRACE_EVENT0("cc", "TileManager::DispatchOneRasterTask");
scoped_ptr<ResourcePool::Resource> resource = PrepareTileForRaster(tile);
@@ -771,7 +783,8 @@ void TileManager::DispatchOneRasterTask(scoped_refptr<Tile> tile) {
resource_id),
tile->content_rect_,
tile->contents_scale(),
- use_cheapness_estimator_),
+ use_cheapness_estimator_,
+ GetRasterTaskMetadata(tile->managed_state())),
base::Bind(&TileManager::OnRasterTaskCompleted,
base::Unretained(this),
tile,
@@ -788,6 +801,7 @@ void TileManager::PerformOneRaster(Tile* tile) {
tile->content_rect_,
tile->contents_scale(),
use_cheapness_estimator_,
+ GetRasterTaskMetadata(tile->managed_state()),
tile->picture_pile(),
&rendering_stats_);
@@ -893,9 +907,12 @@ void TileManager::PerformRaster(uint8* buffer,
const gfx::Rect& rect,
float contents_scale,
bool use_cheapness_estimator,
+ const RasterTaskMetadata& raster_task_metadata,
PicturePileImpl* picture_pile,
RenderingStats* stats) {
- TRACE_EVENT0("cc", "TileManager::PerformRaster");
+ TRACE_EVENT2("cc", "TileManager::PerformRaster",
+ "is_on_pending_tree", raster_task_metadata.is_tile_in_pending_tree_now_bin,
+ "is_low_res", raster_task_metadata.tile_resolution == LOW_RESOLUTION);
reveman 2013/02/13 10:24:39 nit: break these lines so they are not too long.
DCHECK(picture_pile);
DCHECK(buffer);
SkBitmap bitmap;
« cc/tile_manager.h ('K') | « cc/tile_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698