[Cleanup] Files.app: Adds missing JSdoc annotations in file_manager/*.js.

[Cleanup] Files.app: Adds missing JSdoc annotations in file_manager/*.js.

Adds missing JSdos which Closure linter warns. And removes the unused argument of FileTransferController.isDocumentWideEvent_().

BUG=175657
TEST=Files.app launches. 
R=mtomasz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182424

[yoshiki, 2013-02-14 04:19:53]

@mtomasz: PTAL.

[mtomasz, 2013-02-14 04:38:56]

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:52: * @constructor
I think in most places we put @constructor after @param. Please check.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:290: * Send an
event to all the FileManager windows.
Empty line here?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:420: * Convert
string in clipboard to entries and kick off pasting.
Empty line? Here and in other methods?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_selection.js (right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:7: * @constructor
As before.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:160: * Maximum amount
of thumbnails in the preview pane.
Shall we add @type to constants?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_tasks.js (right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_tasks.js:19: * @private
Type missing?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_tasks.js:51: * @return {number=}
amount of tasks.
number= -> number

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:49: * @this
{FileTransferController}
Shall we convert it to FileTransferController.prototype.attachDragSource etc to
be more consistent? (different cl of course)?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:75: /**
Description missing in several methods, but this maybe other cl?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:142: *
Extracts source root from the |dataTransfer| object.
Shall we add an empty line between description and jsdoc fields?

[yoshiki, 2013-02-14 06:17:36]

PATL

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:52: * @constructor
On 2013/02/14 04:38:56, mtomasz wrote:
> I think in most places we put @constructor after @param. Please check.

You're right. The closure-compiler doc says so.
https://developers.google.com/closure/compiler/docs/js-for-compiler

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:290: * Send an
event to all the FileManager windows.
On 2013/02/14 04:38:56, mtomasz wrote:
> Empty line here?

Done.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_copy_manager.js:420: * Convert
string in clipboard to entries and kick off pasting.
On 2013/02/14 04:38:56, mtomasz wrote:
> Empty line? Here and in other methods?

Done.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_selection.js (right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:7: * @constructor
On 2013/02/14 04:38:56, mtomasz wrote:
> As before.

Done.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_selection.js:160: * Maximum amount
of thumbnails in the preview pane.
On 2013/02/14 04:38:56, mtomasz wrote:
> Shall we add @type to constants?

Done.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_tasks.js (right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_tasks.js:19: * @private
On 2013/02/14 04:38:56, mtomasz wrote:
> Type missing?

Done.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_tasks.js:51: * @return {number=}
amount of tasks.
On 2013/02/14 04:38:56, mtomasz wrote:
> number= -> number

Done.

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:49: * @this
{FileTransferController}
Yes, you're right and I'll convert them to
FileTransferController.prototype.attachDragSource after the refactoring period
in another CL.

On 2013/02/14 04:38:56, mtomasz wrote:
> Shall we convert it to FileTransferController.prototype.attachDragSource etc
to
> be more consistent? (different cl of course)?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:75: /**
There are a lot of missing description of method and variables, so I can't do in
this CL. We should add them when we modify around them.

On 2013/02/14 04:38:56, mtomasz wrote:
> Description missing in several methods, but this maybe other cl?

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:142: *
Extracts source root from the |dataTransfer| object.
On 2013/02/14 04:38:56, mtomasz wrote:
> Shall we add an empty line between description and jsdoc fields?

I think we don't always need a blank line. But it is good to add it if it
provides better readability.

[mtomasz, 2013-02-14 07:40:09]

Lgtm with some comments. Thanks!

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/file_transfer_controller.js
(right):

https://codereview.chromium.org/12258003/diff/2001/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/file_transfer_controller.js:75: /**
On 2013/02/14 06:17:36, yoshiki wrote:
> There are a lot of missing description of method and variables, so I can't do
in
> this CL. We should add them when we modify around them.
> 
> On 2013/02/14 04:38:56, mtomasz wrote:
> > Description missing in several methods, but this maybe other cl?
> 

Sgtm!

https://codereview.chromium.org/12258003/diff/12001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/12258003/diff/12001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_copy_manager.js:359: * @private
Sorry, missed this. Should @private be the last one? I've seen it in most places
as the last one.

https://codereview.chromium.org/12258003/diff/12001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_copy_manager.js:620: * @private
Last?

https://codereview.chromium.org/12258003/diff/12001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_copy_manager.js:1251: * @private
Here we have as the last one. That's why my concern.

[yoshiki, 2013-02-14 08:46:11]

https://codereview.chromium.org/12258003/diff/12001/chrome/browser/resources/...
File chrome/browser/resources/file_manager/js/file_copy_manager.js (right):

https://codereview.chromium.org/12258003/diff/12001/chrome/browser/resources/...
chrome/browser/resources/file_manager/js/file_copy_manager.js:359: * @private
Ok, let's put '@private' after '@param' in the future.

On 2013/02/14 07:40:10, mtomasz wrote:
> Sorry, missed this. Should @private be the last one? I've seen it in most
places
> as the last one.