Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 1225793002: Revert of [es6] Bound function names (Closed)

Created:
5 years, 5 months ago by arv (Not doing code reviews)
Modified:
5 years, 5 months ago
Reviewers:
adamk, Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Bound function names (patchset #1 id:1 of https://codereview.chromium.org/1195983002/) Reason for revert: Incorrect behavior Original issue's description: > [es6] Bound function names > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind > > Bound functions should have a name based on the function that was > bound. > > This reverts the revert f2747ed9b48d0e62c7a30da69825ff926aeedbd2. The original > CL was reverted because the Blink layout test broke. I have a CL that disables > these tests at: https://codereview.chromium.org/1196753003/ > > BUG=N > LOG=N > R=adamk > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/b6d950c979f4348138de0ec54e40dcc48d833926 > Cr-Commit-Position: refs/heads/master@{#29193} TBR=adamk@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=N Committed: https://crrev.com/744e4d4fd9316674682bc6ca30ded5866494cc1c Cr-Commit-Position: refs/heads/master@{#29495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M src/v8natives.js View 2 chunks +0 lines, -5 lines 0 comments Download
D test/mjsunit/function-bind-name.js View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
arv (Not doing code reviews)
Created Revert of [es6] Bound function names
5 years, 5 months ago (2015-07-06 15:25:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225793002/1
5 years, 5 months ago (2015-07-06 15:25:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 15:25:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/744e4d4fd9316674682bc6ca30ded5866494cc1c Cr-Commit-Position: refs/heads/master@{#29495}
5 years, 5 months ago (2015-07-06 15:25:56 UTC) #4
arv (Not doing code reviews)
On 2015/07/06 15:25:56, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 5 months ago (2015-07-06 16:05:14 UTC) #5
arv (Not doing code reviews)
5 years, 5 months ago (2015-07-06 16:20:20 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1222363002/ by arv@chromium.org.

The reason for reverting is: This will prevent rolls. Fixing the root issue
instead..

Powered by Google App Engine
This is Rietveld 408576698