Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1225743002: Revert "[turbofan] Add new JSFrameSpecialization reducer." (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[turbofan] Add new JSFrameSpecialization reducer." Also revert "[turbofan] Perform OSR deconstruction early and remove type propagation." This reverts commit b0a852e8c2ce2add1ba8a26d572aff39af0968a3. This reverts commit cdbb6c485b8d07fd4ad1cb000d54a937507e3b3e. NOTRY=true NOTREECHECKS=true BUG=v8:4273 LOG=n TBR=bmeurer@chromium.org Committed: https://crrev.com/9e71cdba48c484c7423fccb969d896307a93e289 Cr-Commit-Position: refs/heads/master@{#29480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -167 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler.h View 6 chunks +12 lines, -22 lines 0 comments Download
M src/compiler.cc View 4 chunks +2 lines, -7 lines 0 comments Download
D src/compiler/js-frame-specialization.h View 1 chunk +0 lines, -44 lines 0 comments Download
D src/compiler/js-frame-specialization.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M src/compiler/osr.cc View 2 chunks +37 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 5 chunks +11 lines, -12 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225743002/1
5 years, 5 months ago (2015-07-06 09:56:23 UTC) #3
Michael Achenbach
FYI: Breaks benchmarks: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20avx2/builds/1303
5 years, 5 months ago (2015-07-06 09:57:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225743002/1
5 years, 5 months ago (2015-07-06 10:00:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-06 10:01:31 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 10:01:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e71cdba48c484c7423fccb969d896307a93e289
Cr-Commit-Position: refs/heads/master@{#29480}

Powered by Google App Engine
This is Rietveld 408576698