Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: sdk/lib/_internal/pub/test/serve/missing_file_test.dart

Issue 122573003: Don't test for file differences in the polling watcher. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise shared test. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/pub.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/test/serve/missing_file_test.dart
diff --git a/sdk/lib/_internal/pub/test/serve/missing_file_test.dart b/sdk/lib/_internal/pub/test/serve/missing_file_test.dart
index 47956b91d129413afc0da96dd18f95d013627d17..3b593ec845eba8ea1776ed21d1e2e4c4c28380cb 100644
--- a/sdk/lib/_internal/pub/test/serve/missing_file_test.dart
+++ b/sdk/lib/_internal/pub/test/serve/missing_file_test.dart
@@ -14,7 +14,7 @@ import 'utils.dart';
main() {
initConfig();
- integration("responds with a 404 for missing files", () {
+ integration("responds with a 404 for missing source files", () {
d.dir(appPath, [
d.appPubspec(),
d.dir("asset", [
@@ -32,13 +32,6 @@ main() {
// assets for them.
pubServe();
- // TODO(rnystrom): When pub serve supports file watching, we'll have to do
- // something here to specifically disable that so that we can get barback
- // into the inconsistent state of thinking there is an asset but where the
- // underlying file does not exist. One option would be configure barback
- // with an insanely long delay between polling to ensure a poll doesn't
- // happen.
-
// Now delete them.
schedule(() {
deleteEntry(path.join(sandboxDir, appPath, "asset", "nope.png"));
@@ -46,6 +39,11 @@ main() {
deleteEntry(path.join(sandboxDir, appPath, "web", "index.html"));
}, "delete files");
+ // Now request them.
+ // TODO(rnystrom): It's possible for these requests to happen quickly
+ // enough that the file system hasn't notified for the deletions yet. If
+ // that happens, we can probably just add a short delay here.
+
requestShould404("index.html");
requestShould404("packages/myapp/nope.dart");
requestShould404("assets/myapp/nope.png");
« no previous file with comments | « sdk/lib/_internal/pub/pub.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698