Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1225713003: Add IdleTask API to v8::Platform. (Closed)

Created:
5 years, 5 months ago by ulan
Modified:
5 years, 5 months ago
Reviewers:
rmcilroy
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add IdleTask API to v8::Platform. BUG=chromium:490559 LOG=NO Committed: https://crrev.com/a9c7712eb8e464cf1ee2f35662dbbfe5046cd77a Cr-Commit-Position: refs/heads/master@{#29676}

Patch Set 1 #

Patch Set 2 : Rename #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M include/v8-platform.h View 1 2 2 chunks +33 lines, -1 line 0 comments Download
M src/libplatform/default-platform.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/libplatform/default-platform.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL. Discussion doc contains links to other CLs in gin and blink: https://goo.gl/V0ZoP9. Thanks!
5 years, 5 months ago (2015-07-14 13:55:49 UTC) #2
rmcilroy
lgtm, thanks.
5 years, 5 months ago (2015-07-15 11:22:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1225713003/40001
5 years, 5 months ago (2015-07-15 11:25:05 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-15 11:50:54 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 11:51:10 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a9c7712eb8e464cf1ee2f35662dbbfe5046cd77a
Cr-Commit-Position: refs/heads/master@{#29676}

Powered by Google App Engine
This is Rietveld 408576698