Issue 12257033: [content shell] add stubs for all missing WebTestDelegate methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12257033: [content shell] add stubs for all missing WebTestDelegate methods (Closed)

Created:
7 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 10 months ago

Reviewers:
marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[content shell] add stubs for all missing WebTestDelegate methods BUG=111316 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182451

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+273 lines, -34 lines)			Patch
M	content/shell/shell_content_renderer_client.cc	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/shell/webkit_test_runner.h	View	1	3 chunks	+51 lines, -9 lines	0 comments	Download
M	content/shell/webkit_test_runner.cc	View	1	7 chunks	+216 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

7 years, 10 months ago (2013-02-14 12:05:51 UTC) #2

lgtm

https://codereview.chromium.org/12257033/diff/1/content/shell/webkit_test_run...
File content/shell/webkit_test_runner.cc (right):

https://codereview.chromium.org/12257033/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:170: window_count_++;
nit: why not ++window_count;

https://codereview.chromium.org/12257033/diff/1/content/shell/webkit_test_run...
content/shell/webkit_test_runner.cc:174: window_count_--;
nit2

Expand Messages | Collapse Messages