Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4954)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc

Issue 12257015: Disabled FileBrowserResourceThrottleExtensionApiTest.Basic on ChromeOS-- (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc b/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
index fbe881930a00dcc46ad11fa8baf01ea43a5e23e5..eb690e84e53670fc209c4798b52228199dbd4200 100644
--- a/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
@@ -244,9 +244,16 @@ class FileBrowserResourceThrottleExtensionApiTest : public ExtensionApiTest {
base::ScopedTempDir downloads_dir_;
};
+// http://crbug.com/176082: This test flaky on chrome OS asan bots.
raymes 2013/02/13 21:28:05 nit: chrome OS -> ChromeOS asan -> ASAN
Randy Smith (Not in Mondays) 2013/02/13 21:31:23 Done.
+#if defined(OS_CHROME)
raymes 2013/02/13 21:28:05 OS_CHROMEOS?
Randy Smith (Not in Mondays) 2013/02/13 21:31:23 Right you are. Sorry, coulda sworn it was OS_CHRO
+#define MAYBE_Basic DISABLED_Basic
+#else
+#define MAYBE_Basic Basic
+#endif
// Tests that invoking FileBrowserResourceThrottle with handleable MIME type
// actually invokes the fileBrowserHandler.onExecuteContnentHandler event.
-IN_PROC_BROWSER_TEST_F(FileBrowserResourceThrottleExtensionApiTest, Basic) {
+IN_PROC_BROWSER_TEST_F(FileBrowserResourceThrottleExtensionApiTest,
+ MAYBE_Basic) {
ASSERT_TRUE(LoadTestExtension()) << message_;
ResultCatcher catcher;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698