Issue 12257015: Disabled FileBrowserResourceThrottleExtensionApiTest.Basic on ChromeOS--

Issue 12257015: Disabled FileBrowserResourceThrottleExtensionApiTest.Basic on ChromeOS-- (Closed)

Created:
7 years, 10 months ago by Randy Smith (Not in Mondays)

Modified:
7 years, 10 months ago

Reviewers:
raymes

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disabled FileBrowserResourceThrottleExtensionApiTest.Basic on ChromeOS-- it's failing flakily on the Chrome OS ASAN bots. BUG=176082 TBR=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=182311

Patch Set 1 #

Total comments: 4

Patch Set 2 : Incorporated comments. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

raymes

https://codereview.chromium.org/12257015/diff/1/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc File chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc (right): https://codereview.chromium.org/12257015/diff/1/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc#newcode247 chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc:247: // http://crbug.com/176082: This test flaky on chrome OS asan ...

7 years, 10 months ago (2013-02-13 21:28:05 UTC) #1

Randy Smith (Not in Mondays)

PTAL. https://codereview.chromium.org/12257015/diff/1/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc File chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc (right): https://codereview.chromium.org/12257015/diff/1/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc#newcode247 chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc:247: // http://crbug.com/176082: This test flaky on chrome OS ...

7 years, 10 months ago (2013-02-13 21:31:23 UTC) #2

raymes

7 years, 10 months ago (2013-02-13 21:32:21 UTC) #3

lgtm, thanks!

On Wed, Feb 13, 2013 at 1:31 PM,  <rdsmith@chromium.org> wrote:
> Reviewers: raymes,
>
> Message:
> PTAL.
>
>
>
>
>
https://codereview.chromium.org/12257015/diff/1/chrome/browser/chromeos/exten...
> File
>
chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
> (right):
>
>
https://codereview.chromium.org/12257015/diff/1/chrome/browser/chromeos/exten...
>
chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc:247:
> // http://crbug.com/176082: This test flaky on chrome OS asan bots.
> On 2013/02/13 21:28:05, raymes wrote:
>>
>> nit: chrome OS -> ChromeOS
>> asan -> ASAN
>
>
> Done.
>
>
>
https://codereview.chromium.org/12257015/diff/1/chrome/browser/chromeos/exten...
>
chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc:248:
> #if defined(OS_CHROME)
> On 2013/02/13 21:28:05, raymes wrote:
>>
>> OS_CHROMEOS?
>
>
> Right you are.  Sorry, coulda sworn it was OS_CHROME.  Done.
>
> Description:
> Disabled FileBrowserResourceThrottleExtensionApiTest.Basic on ChromeOS--
> it's failing flakily on the Chrome OS ASAN bots.
>
> BUG=176082
>
>
> Please review this at https://codereview.chromium.org/12257015/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M
>
chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
>
>
> Index:
>
chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
> diff --git
>
a/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
>
b/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
> index
>
fbe881930a00dcc46ad11fa8baf01ea43a5e23e5..a8a54709324fd083cf2c84e5f81434a5813d4a71
> 100644
> ---
>
a/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
> +++
>
b/chrome/browser/chromeos/extensions/file_browser_resource_throttle_browsertest.cc
> @@ -244,9 +244,16 @@ class FileBrowserResourceThrottleExtensionApiTest :
> public ExtensionApiTest {
>    base::ScopedTempDir downloads_dir_;
>  };
>
> +// http://crbug.com/176082: This test flaky on Chrome OS ASAN bots.
> +#if defined(OS_CHROMEOS)
> +#define MAYBE_Basic DISABLED_Basic
> +#else
> +#define MAYBE_Basic Basic
> +#endif
>  // Tests that invoking FileBrowserResourceThrottle with handleable MIME
> type
>  // actually invokes the fileBrowserHandler.onExecuteContnentHandler event.
> -IN_PROC_BROWSER_TEST_F(FileBrowserResourceThrottleExtensionApiTest, Basic)
> {
> +IN_PROC_BROWSER_TEST_F(FileBrowserResourceThrottleExtensionApiTest,
> +                       MAYBE_Basic) {
>    ASSERT_TRUE(LoadTestExtension()) << message_;
>
>    ResultCatcher catcher;
>
>

Expand Messages | Collapse Messages